public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 8/8] volume rescan: also consider volumes listed only with an approximate size
Date: Wed, 13 May 2026 15:05:40 +0200	[thread overview]
Message-ID: <20260513130548.143270-9-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260513130548.143270-1-f.ebner@proxmox.com>

For qcow2 volumes on LVM, if the LV is inactive, only an approximate
size is returned instead of the exact size. Handle this case too.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 3ee58ec5..fe2f620e 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -6739,7 +6739,7 @@ sub scan_volids {
     my $volid_hash = {};
     foreach my $storeid (keys %$info) {
         foreach my $item (@{ $info->{$storeid} }) {
-            next if !($item->{volid} && $item->{size});
+            next if !($item->{volid} && ($item->{size} || $item->{'approximate-size'}));
             $item->{path} = PVE::Storage::path($cfg, $item->{volid});
             $volid_hash->{ $item->{volid} } = $item;
         }
@@ -6763,7 +6763,7 @@ sub update_disk_config {
 
     my $referencedpath = {};
 
-    # update size info
+    # update size info, when the exact size is available
     PVE::QemuConfig->foreach_volume(
         $conf,
         sub {
@@ -6781,6 +6781,7 @@ sub update_disk_config {
 
             return if drive_is_cdrom($drive);
             return if !$volume;
+            return if !defined($volume->{size});
 
             my ($updated, $msg) =
                 PVE::QemuServer::Drive::update_disksize($drive, $volume->{size});
-- 
2.47.3





      parent reply	other threads:[~2026-05-13 13:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 13:05 [PATCH-SERIES storage/manager/container/qemu-server 0/8] fix #6819: lvm plugin: list images: use approximate size for inactive qcow2 volumes Fiona Ebner
2026-05-13 13:05 ` [PATCH storage 1/8] api: content: add missing imports and group/order according to style guide Fiona Ebner
2026-05-13 13:05 ` [PATCH storage 2/8] pvesm: " Fiona Ebner
2026-05-13 13:05 ` [PATCH storage 3/8] api/cli: list content: declare size optional and add approximate-size Fiona Ebner
2026-05-13 13:05 ` [PATCH storage 4/8] fix #6819: lvm plugin: list images: use approximate size for inactive qcow2 volumes Fiona Ebner
2026-05-13 13:05 ` [PATCH manager 5/8] fix #6819: storage: content view: fallback to approximate size Fiona Ebner
2026-05-13 13:05 ` [PATCH container 6/8] volume rescan: also consider zero-sized volumes Fiona Ebner
2026-05-13 13:05 ` [PATCH container 7/8] volume rescan: also consider volumes listed only with an approximate size Fiona Ebner
2026-05-13 13:05 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260513130548.143270-9-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal