From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 09EAA1FF13A for ; Wed, 13 May 2026 15:07:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 60EA1DEAF; Wed, 13 May 2026 15:06:45 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 8/8] volume rescan: also consider volumes listed only with an approximate size Date: Wed, 13 May 2026 15:05:40 +0200 Message-ID: <20260513130548.143270-9-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260513130548.143270-1-f.ebner@proxmox.com> References: <20260513130548.143270-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778677548291 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BIG4IM4U6FPMUOT5BIVQLVZD2V6NWGHT X-Message-ID-Hash: BIG4IM4U6FPMUOT5BIVQLVZD2V6NWGHT X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For qcow2 volumes on LVM, if the LV is inactive, only an approximate size is returned instead of the exact size. Handle this case too. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 3ee58ec5..fe2f620e 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -6739,7 +6739,7 @@ sub scan_volids { my $volid_hash = {}; foreach my $storeid (keys %$info) { foreach my $item (@{ $info->{$storeid} }) { - next if !($item->{volid} && $item->{size}); + next if !($item->{volid} && ($item->{size} || $item->{'approximate-size'})); $item->{path} = PVE::Storage::path($cfg, $item->{volid}); $volid_hash->{ $item->{volid} } = $item; } @@ -6763,7 +6763,7 @@ sub update_disk_config { my $referencedpath = {}; - # update size info + # update size info, when the exact size is available PVE::QemuConfig->foreach_volume( $conf, sub { @@ -6781,6 +6781,7 @@ sub update_disk_config { return if drive_is_cdrom($drive); return if !$volume; + return if !defined($volume->{size}); my ($updated, $msg) = PVE::QemuServer::Drive::update_disksize($drive, $volume->{size}); -- 2.47.3