[PATCH storage 4/8] fix #6819: lvm plugin: list images: use approximate size for inactive qcow2 volumes

[Fiona Ebner <f.ebner@proxmox.com>]

For qcow2 volumes on LVM, the exact size can only be queried when the
LV is active. For a shared LVM, an LV might already be active on
another node, so it must not be activated. Also, doing so for each
volume would be costly. Instead, return only the approximate size when
the LV is inactive.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/Storage/LVMPlugin.pm | 33 +++++++++++++++++++++------------
 1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
index 3a35e38..4564f5b 100644
--- a/src/PVE/Storage/LVMPlugin.pm
+++ b/src/PVE/Storage/LVMPlugin.pm
@@ -833,19 +833,28 @@ sub list_images {
             }
 
             my $format = ($class->parse_volname($volname))[6];
-            my $size =
-                $format eq 'qcow2'
-                ? $class->volume_size_info($scfg, $storeid, $volname)
-                : $info->{lv_size};
+            my $entry = {
+                volid => $volid,
+                format => $format,
+                vmid => $owner,
+                ctime => $info->{ctime},
+            };
 
-            push @$res,
-                {
-                    volid => $volid,
-                    format => $format,
-                    size => $size,
-                    vmid => $owner,
-                    ctime => $info->{ctime},
-                };
+            if ($format eq 'qcow2') {
+                my $size;
+                if ($info->{lv_state} eq 'a') {
+                    $size = $class->volume_size_info($scfg, $storeid, $volname);
+                }
+                if (defined($size)) {
+                    $entry->{size} = $size;
+                } else {
+                    $entry->{'approximate-size'} = $info->{lv_size};
+                }
+            } else {
+                $entry->{size} = $info->{lv_size};
+            }
+
+            push @$res, $entry;
         }
     }
 
-- 
2.47.3