[PATCH v2 manager 0/1] ceph: init: clean up deprecated pg_bits parameter

[PATCH v2 manager 0/1] ceph: init: clean up deprecated pg_bits parameter

[Kefu Chai]

Changes since v1:
- Keep the pg_bits parameter definition in the API schema as a documented
  no-op, per Thomas's feedback that removing an API parameter is a breaking
  change that should not happen during the 9.x cycle.
- Defer full parameter removal to PVE 10.
- Fix typos in the TODO comment and description.
- The dead-code comment removal from v1 is kept as-is.

Kefu Chai (1):
  ceph: init: clean up deprecated pg_bits parameter

 PVE/API2/Ceph.pm | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

-- 
2.47.3

[PATCH v2 manager 1/1] ceph: init: clean up deprecated pg_bits parameter

[Kefu Chai]

The pg_bits parameter was deprecated in commit 9b15baf (PVE 8) after the
underlying Ceph config options (osd_pg_bits / osd_pgp_bits) were removed
from Ceph in v13.0.2. It has been a guaranteed no-op on every cluster
PVE 9 can manage.

Removing the API parameter itself would be a breaking change during the
9.x release cycle, so keep it as a documented no-op until PVE 10. Only
remove the dead-code comments that referenced it in the implementation,
and fix the typos in the TODO and description.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 PVE/API2/Ceph.pm | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
index 231b751c..bf8cd5bb 100644
--- a/PVE/API2/Ceph.pm
+++ b/PVE/API2/Ceph.pm
@@ -161,11 +161,11 @@ __PACKAGE__->register_method({
                 minimum => 1,
                 maximum => 7,
             },
-            # TODO: deprecrated, remove with PVE 9
+            # TODO: deprecated, remove with PVE 10
             pg_bits => {
                 description => "Placement group bits, used to specify the "
-                    . "default number of placement groups.\n\nDepreacted. This "
-                    . "setting was deprecated in recent Ceph versions.",
+                    . "default number of placement groups.\n\nDeprecated. This "
+                    . "setting has been ignored since Ceph Nautilus.",
                 type => 'integer',
                 default => 6,
                 optional => 1,
@@ -238,9 +238,6 @@ __PACKAGE__->register_method({
                         'mon_allow_pool_delete' => 'true',
                     };
 
-                    # this does not work for default pools
-                    #'osd pool default pg num' => $pg_num,
-                    #'osd pool default pgp num' => $pg_num,
                 }
 
                 if ($auth eq 'cephx') {
-- 
2.47.3

Re: [PATCH v2 manager 1/1] ceph: init: clean up deprecated pg_bits parameter

[Kefu Chai]

Gentle ping. The v2 patch (keeping pg_bits as a documented no-op per
Thomas's feedback) still applies cleanly against current master. Happy to
resend if a fresh look is easier.