From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5C8641FF143 for ; Sat, 28 Mar 2026 12:23:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5592854CE; Sat, 28 Mar 2026 12:23:51 +0100 (CET) From: Kefu Chai To: pve-devel@lists.proxmox.com Subject: [PATCH v2 manager 1/1] ceph: init: clean up deprecated pg_bits parameter Date: Sat, 28 Mar 2026 19:23:07 +0800 Message-ID: <20260328112307.1131390-2-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260328112307.1131390-1-k.chai@proxmox.com> References: <20260328112307.1131390-1-k.chai@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774696945546 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.366 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JZ7IPT4R3FY4YJLVWR5LST7ZKJ46R2CN X-Message-ID-Hash: JZ7IPT4R3FY4YJLVWR5LST7ZKJ46R2CN X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The pg_bits parameter was deprecated in commit 9b15baf (PVE 8) after the underlying Ceph config options (osd_pg_bits / osd_pgp_bits) were removed from Ceph in v13.0.2. It has been a guaranteed no-op on every cluster PVE 9 can manage. Removing the API parameter itself would be a breaking change during the 9.x release cycle, so keep it as a documented no-op until PVE 10. Only remove the dead-code comments that referenced it in the implementation, and fix the typos in the TODO and description. Signed-off-by: Kefu Chai --- PVE/API2/Ceph.pm | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 231b751c..bf8cd5bb 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -161,11 +161,11 @@ __PACKAGE__->register_method({ minimum => 1, maximum => 7, }, - # TODO: deprecrated, remove with PVE 9 + # TODO: deprecated, remove with PVE 10 pg_bits => { description => "Placement group bits, used to specify the " - . "default number of placement groups.\n\nDepreacted. This " - . "setting was deprecated in recent Ceph versions.", + . "default number of placement groups.\n\nDeprecated. This " + . "setting has been ignored since Ceph Nautilus.", type => 'integer', default => 6, optional => 1, @@ -238,9 +238,6 @@ __PACKAGE__->register_method({ 'mon_allow_pool_delete' => 'true', }; - # this does not work for default pools - #'osd pool default pg num' => $pg_num, - #'osd pool default pgp num' => $pg_num, } if ($auth eq 'cephx') { -- 2.47.3