[PATCH qemu-server 1/3] d/tmpfiles: add configuration to auto-create /run/qemu-server directory

[Fiona Ebner <f.ebner@proxmox.com>]

Some code paths use /run/qemu-server, some code paths use
/var/run/qemu-server. Nothing currently ensures that the former
directory exists, but usually, /var/run is a symlink to /run, so it
does work in practice. The latter directory is created in the
Helpers.pm module. Usage of these paths should be aligned for the next
major release.

If /var/run is a symlink to /run like usual, then this change makes
the permissions tighter, because the directory /var/run/qemu-server
was created with 0755 permissions by the Helpers.pm module and is now
created via the tmpfiles configuration. The permissions chosen are
0750 with user root and group www-data. This is in line with what
/run/pve-cluster and /run/pve have.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 debian/tmpfiles               | 2 ++
 src/PVE/QemuServer/Helpers.pm | 2 ++
 2 files changed, 4 insertions(+)
 create mode 100644 debian/tmpfiles

diff --git a/debian/tmpfiles b/debian/tmpfiles
new file mode 100644
index 00000000..3bbe100c
--- /dev/null
+++ b/debian/tmpfiles
@@ -0,0 +1,2 @@
+#Type Path             Mode User Group     Age Argument
+d     /run/qemu-server 0750 root www-data  -   -
diff --git a/src/PVE/QemuServer/Helpers.pm b/src/PVE/QemuServer/Helpers.pm
index 65f4ce5f..dd17eef5 100644
--- a/src/PVE/QemuServer/Helpers.pm
+++ b/src/PVE/QemuServer/Helpers.pm
@@ -81,6 +81,8 @@ sub kvm_user_version {
 
 # Paths and directories
 
+# FIXME: MAJOR VERSION: use /run/qemu-server everywhere instead of mixing /run and /var/run and rely
+# on debian/tmpfiles config to create the directory.
 our $var_run_tmpdir = "/var/run/qemu-server";
 mkdir $var_run_tmpdir;
 
-- 
2.47.3