public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH qemu-server master+stable-bookworm] check efi vars: promote message about missing MS 2023 certs to warning
@ 2026-04-21  8:45 Fiona Ebner
  0 siblings, 0 replies; only message in thread
From: Fiona Ebner @ 2026-04-21  8:45 UTC (permalink / raw)
  To: pve-devel

The expiration date of the MS 2011 UEFI certificates is June 2026 and
is getting closer, so the message about missing MS 2023 certificates
deserves to be a warning.

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer.pm | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 2a469fff..b3ea3f76 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -5423,14 +5423,12 @@ my sub check_efi_vars {
 
     my $efidisk = parse_drive('efidisk0', $conf->{efidisk0});
     if (PVE::QemuServer::OVMF::should_enroll_ms_2023_cert($efidisk)) {
-        # TODO: make the first print a log_warn with PVE 9.2 to make it more noticeable!
-        print "EFI disk without 'ms-cert=2023k' option, suggesting that not all UEFI 2023\n";
-        print "certificates from Microsoft are enrolled yet. The UEFI 2011 certificates expire\n";
-        print
-            "in June 2026! The new certificates are required for secure boot update for Windows\n";
-        print "and common Linux distributions. Use 'Disk Action > Enroll Updated Certificates'\n";
-        print "in the UI or, while the VM is shut down, run 'qm enroll-efi-keys $vmid' to enroll\n";
-        print "the new certificates.\n\n";
+        log_warn("EFI disk without 'ms-cert=2023k' option, suggesting that not all UEFI 2023\n"
+            . "certificates from Microsoft are enrolled yet.");
+        print "The UEFI 2011 certificates expire in June 2026! The new certificates are required\n";
+        print "for secure boot update for Windows and common Linux distributions.\n";
+        print "Use 'Disk Action > Enroll Updated Certificates' in the UI or, while the VM is\n";
+        print "shut down, run 'qm enroll-efi-keys $vmid' to enroll the new certificates.\n\n";
         print "For Windows with BitLocker, run the following command inside Powershell:\n";
         print "  manage-bde -protectors -disable <drive>\n";
         print "for each drive with BitLocker (for example, <drive> could be 'C:').\n";
-- 
2.47.3





^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-04-21  8:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-21  8:45 [PATCH qemu-server master+stable-bookworm] check efi vars: promote message about missing MS 2023 certs to warning Fiona Ebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal