From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 38EBD1FF142 for ; Tue, 21 Apr 2026 10:47:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04C6718E5C; Tue, 21 Apr 2026 10:47:02 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server master+stable-bookworm] check efi vars: promote message about missing MS 2023 certs to warning Date: Tue, 21 Apr 2026 10:45:33 +0200 Message-ID: <20260421084622.20641-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776761101020 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Message-ID-Hash: XF27WSY56GRGZGF43LQZNAYK6752RIMC X-Message-ID-Hash: XF27WSY56GRGZGF43LQZNAYK6752RIMC X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The expiration date of the MS 2011 UEFI certificates is June 2026 and is getting closer, so the message about missing MS 2023 certificates deserves to be a warning. Suggested-by: Thomas Lamprecht Signed-off-by: Fiona Ebner --- src/PVE/QemuServer.pm | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 2a469fff..b3ea3f76 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -5423,14 +5423,12 @@ my sub check_efi_vars { my $efidisk = parse_drive('efidisk0', $conf->{efidisk0}); if (PVE::QemuServer::OVMF::should_enroll_ms_2023_cert($efidisk)) { - # TODO: make the first print a log_warn with PVE 9.2 to make it more noticeable! - print "EFI disk without 'ms-cert=2023k' option, suggesting that not all UEFI 2023\n"; - print "certificates from Microsoft are enrolled yet. The UEFI 2011 certificates expire\n"; - print - "in June 2026! The new certificates are required for secure boot update for Windows\n"; - print "and common Linux distributions. Use 'Disk Action > Enroll Updated Certificates'\n"; - print "in the UI or, while the VM is shut down, run 'qm enroll-efi-keys $vmid' to enroll\n"; - print "the new certificates.\n\n"; + log_warn("EFI disk without 'ms-cert=2023k' option, suggesting that not all UEFI 2023\n" + . "certificates from Microsoft are enrolled yet."); + print "The UEFI 2011 certificates expire in June 2026! The new certificates are required\n"; + print "for secure boot update for Windows and common Linux distributions.\n"; + print "Use 'Disk Action > Enroll Updated Certificates' in the UI or, while the VM is\n"; + print "shut down, run 'qm enroll-efi-keys $vmid' to enroll the new certificates.\n\n"; print "For Windows with BitLocker, run the following command inside Powershell:\n"; print " manage-bde -protectors -disable \n"; print "for each drive with BitLocker (for example, could be 'C:').\n"; -- 2.47.3