From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [PATCH network/proxmox-perl-rs 0/3] Fix listing fabric nodes of hosts in multiple fabrics
Date: Sat, 21 Nov 2026 21:58:59 +0100 [thread overview]
Message-ID: <179528709033033.3238989.4504280913050117835.b4-ty@b4> (raw)
In-Reply-To: <20261120152251.265831-1-g.goller@proxmox.com>
On Fri, 20 Nov 2026 16:22:43 +0100, Gabriel Goller wrote:
> GET /cluster/sdn/fabrics/node returned only one node per host. The nodes
> returned by list_nodes() in pve-rs were keyed by the node name, so if a
> host was part of multiple fabrics, the fabric that sorts last overwrote
> the others. Among others, this hid the WireGuard interfaces in the node
> edit window of OSPF and BGP fabrics. The proxmox-perl-rs patch keys the
> nodes by section ID (<fabric>_<node>) instead.
>
> [...]
Applied, thanks!
Tested with a node in an OpenFabric and a WG fabric: the node list has
both now.
What I added on top:
- ee1d3e7 ("api: fabrics: share the permission check of the fabric node
lists"), with a test for a node in two fabrics.
- 6dab917 ("api: fabrics: describe pending changes in the list
schemas"): a new pending node did not match the old schemas.
[proxmox-perl-rs]
[1/3] pve-rs: fabrics: list nodes of all fabrics
commit: 1fcc8bd562964f695dd358d02499ee9e9f065ead
[pve-network]
[2/3] api: fabrics: check node permissions with the node name in list_all
commit: 5eef385fdeb6b1a39c663d6cb0b8b5bfcf39a77a
[3/3] api: fabrics: check node permissions with the node name in list_nodes
commit: d947d6814e21710920525a1b8871eb44f6552a00
prev parent reply other threads:[~2026-11-21 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 15:22 [PATCH network/proxmox-perl-rs 0/3] Fix listing fabric nodes of hosts in multiple fabrics Gabriel Goller
2026-11-20 15:22 ` [PATCH proxmox-perl-rs 1/3] pve-rs: fabrics: list nodes of all fabrics Gabriel Goller
2026-11-20 15:22 ` [PATCH pve-network 2/3] api: fabrics: check node permissions with the node name in list_all Gabriel Goller
2026-11-20 15:22 ` [PATCH pve-network 3/3] api: fabrics: check node permissions with the node name in list_nodes Gabriel Goller
2026-11-21 20:58 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179528709033033.3238989.4504280913050117835.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox