From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 4AB3D1FF0E4 for ; Sat, 21 Nov 2026 21:59:24 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 20A0D21522; Sat, 21 Nov 2026 21:59:21 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Gabriel Goller Subject: Re: [PATCH network/proxmox-perl-rs 0/3] Fix listing fabric nodes of hosts in multiple fabrics Date: Sat, 21 Nov 2026 21:58:59 +0100 Message-ID: <179528709033033.3238989.4504280913050117835.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120152251.265831-1-g.goller@proxmox.com> References: <20261120152251.265831-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795294756164 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OX6BKV2KIH6TYNOOTU5ZY4WCQYD3WIUD X-Message-ID-Hash: OX6BKV2KIH6TYNOOTU5ZY4WCQYD3WIUD X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 20 Nov 2026 16:22:43 +0100, Gabriel Goller wrote: > GET /cluster/sdn/fabrics/node returned only one node per host. The nodes > returned by list_nodes() in pve-rs were keyed by the node name, so if a > host was part of multiple fabrics, the fabric that sorts last overwrote > the others. Among others, this hid the WireGuard interfaces in the node > edit window of OSPF and BGP fabrics. The proxmox-perl-rs patch keys the > nodes by section ID (_) instead. > > [...] Applied, thanks! Tested with a node in an OpenFabric and a WG fabric: the node list has both now. What I added on top: - ee1d3e7 ("api: fabrics: share the permission check of the fabric node lists"), with a test for a node in two fabrics. - 6dab917 ("api: fabrics: describe pending changes in the list schemas"): a new pending node did not match the old schemas. [proxmox-perl-rs] [1/3] pve-rs: fabrics: list nodes of all fabrics commit: 1fcc8bd562964f695dd358d02499ee9e9f065ead [pve-network] [2/3] api: fabrics: check node permissions with the node name in list_all commit: 5eef385fdeb6b1a39c663d6cb0b8b5bfcf39a77a [3/3] api: fabrics: check node permissions with the node name in list_nodes commit: d947d6814e21710920525a1b8871eb44f6552a00