public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH network/proxmox-perl-rs 0/3] Fix listing fabric nodes of hosts in multiple fabrics
Date: Fri, 20 Nov 2026 16:22:43 +0100	[thread overview]
Message-ID: <20261120152251.265831-1-g.goller@proxmox.com> (raw)

GET /cluster/sdn/fabrics/node returned only one node per host. The nodes
returned by list_nodes() in pve-rs were keyed by the node name, so if a
host was part of multiple fabrics, the fabric that sorts last overwrote
the others. Among others, this hid the WireGuard interfaces in the node
edit window of OSPF and BGP fabrics. The proxmox-perl-rs patch keys the
nodes by section ID (<fabric>_<node>) instead.

The API endpoints used these keys as node names for the permission check
on /nodes/<node>. GET /cluster/sdn/fabrics/all always got section IDs from
list_all(), so users with permissions only on single nodes never saw any
fabric node there. The first pve-network patch fixes this. The second
one does the same for GET /cluster/sdn/fabrics/node, which is needed with
the proxmox-perl-rs patch. It works with the old pve-rs too, so it should
be applied no later than the proxmox-perl-rs patch.


proxmox-perl-rs:

Gabriel Goller (1):
  pve-rs: fabrics: list nodes of all fabrics

 pve-rs/src/bindings/sdn/fabrics.rs | 41 ++++++++++++++++++++++++++++--
 1 file changed, 39 insertions(+), 2 deletions(-)


pve-network:

Gabriel Goller (2):
  api: fabrics: check node permissions with the node name in list_all
  api: fabrics: check node permissions with the node name in list_nodes

 src/PVE/API2/Network/SDN/Fabrics.pm      | 5 +++--
 src/PVE/API2/Network/SDN/Fabrics/Node.pm | 7 ++++---
 2 files changed, 7 insertions(+), 5 deletions(-)


Summary over all repositories:
  3 files changed, 46 insertions(+), 7 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-11-20 15:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 15:22 Gabriel Goller [this message]
2026-11-20 15:22 ` [PATCH proxmox-perl-rs 1/3] pve-rs: fabrics: list nodes of all fabrics Gabriel Goller
2026-11-20 15:22 ` [PATCH pve-network 2/3] api: fabrics: check node permissions with the node name in list_all Gabriel Goller
2026-11-20 15:22 ` [PATCH pve-network 3/3] api: fabrics: check node permissions with the node name in list_nodes Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120152251.265831-1-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal