From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 3B13D1FF0AF for ; Fri, 20 Nov 2026 16:23:13 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 59E42217F6; Fri, 20 Nov 2026 16:23:01 +0100 (CET) From: Gabriel Goller To: pve-devel@lists.proxmox.com Subject: [PATCH network/proxmox-perl-rs 0/3] Fix listing fabric nodes of hosts in multiple fabrics Date: Fri, 20 Nov 2026 16:22:43 +0100 Message-ID: <20261120152251.265831-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795188176125 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NLSR4T7DOXTPS75C2VK6SLNB5RECTVYO X-Message-ID-Hash: NLSR4T7DOXTPS75C2VK6SLNB5RECTVYO X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: GET /cluster/sdn/fabrics/node returned only one node per host. The nodes returned by list_nodes() in pve-rs were keyed by the node name, so if a host was part of multiple fabrics, the fabric that sorts last overwrote the others. Among others, this hid the WireGuard interfaces in the node edit window of OSPF and BGP fabrics. The proxmox-perl-rs patch keys the nodes by section ID (_) instead. The API endpoints used these keys as node names for the permission check on /nodes/. GET /cluster/sdn/fabrics/all always got section IDs from list_all(), so users with permissions only on single nodes never saw any fabric node there. The first pve-network patch fixes this. The second one does the same for GET /cluster/sdn/fabrics/node, which is needed with the proxmox-perl-rs patch. It works with the old pve-rs too, so it should be applied no later than the proxmox-perl-rs patch. proxmox-perl-rs: Gabriel Goller (1): pve-rs: fabrics: list nodes of all fabrics pve-rs/src/bindings/sdn/fabrics.rs | 41 ++++++++++++++++++++++++++++-- 1 file changed, 39 insertions(+), 2 deletions(-) pve-network: Gabriel Goller (2): api: fabrics: check node permissions with the node name in list_all api: fabrics: check node permissions with the node name in list_nodes src/PVE/API2/Network/SDN/Fabrics.pm | 5 +++-- src/PVE/API2/Network/SDN/Fabrics/Node.pm | 7 ++++--- 2 files changed, 7 insertions(+), 5 deletions(-) Summary over all repositories: 3 files changed, 46 insertions(+), 7 deletions(-) -- Generated by murpp 0.11.0