public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Rusovac <d.rusovac@proxmox.com>
Subject: applied: [PATCH-SERIES docs/ha-manager/manager v5 00/10] fix #6144: add api and ui for node maintenance mode
Date: Thu, 19 Nov 2026 23:28:53 +0100	[thread overview]
Message-ID: <179512671723.3646511.14162859267761864497.b4-ty@b4> (raw)
In-Reply-To: <20261119095931.1748970-1-d.rusovac@proxmox.com>

On Thu, 19 Nov 2026 10:59:21 +0100, Dominik Rusovac wrote:
> this picks up Thomas' v3 [0], rebased onto current master and reworked
> in a few places; thx for the nice work Thomas! I added `Originally-by`
> trailers
> 
> node maintenance mode can currently only be enabled/disabled with the HA
> manager's CRM command in the CLI. this series adds an API endpoint and a
> 'Node Maintenance' menu in the HA status panel for it
> 
> [...]

Applied, thanks!

I folded some changes into the patches, and added two follow-ups:

ha-manager:
- the shared check returns the log level and reason instead of taking a
  log callback, so that the CRM and the CLI each phrase the message; the
  'not online' message uses the common format now too
- cli: requesting maintenance mode again for a node it is already
  requested for succeeds, instead of failing with the CRM's "already in
  maintenance state" log message. The early check only runs while the
  recorded state is current, i.e. with an active CRM and no other queued
  command such as arm-ha, otherwise the CRM decides
- status API: parse the queued commands in PVE::HA::Config
- follow-up: the CRM now records an enable request for a node that is in
  maintenance without one, e.g. while it shuts down with the 'migrate'
  shutdown policy, so that it stays in maintenance once back online.
  This also keeps an enable queued right after a disable

manager:
- the endpoint requires Sys.Modify on / instead of /nodes/{node}, as
  maintenance moves HA resources to other nodes; the UI checks the same
- ui: Enable is also disabled while HA is still disarming. The spinner
  tracks pending requests in a Map, as a node named 'constructor' was
  always pending, keeps them on failed loads and compares them to the
  start of the load that finished

docs:
- mention that requests for nodes that are not online are rejected,
  except during a 'migrate' policy shutdown, which a follow-up documents

[pve-docs] applied to pve-docs.git (master)
[1/1] ha-manager: maintenance mode: mention web ui menu
      https://git.proxmox.com/?p=pve-docs.git;a=commitdiff;h=744af141b66235061a729ba226bd2b0644f6cf25

[pve-ha-manager] applied to pve-ha-manager.git (master)
[1/6] test: add test for ignoring maintenance mode request
      https://git.proxmox.com/?p=pve-ha-manager.git;a=commitdiff;h=122e20ce41c19bd62506413b91b39b0e13e4f5fe
[2/6] manager: standardize log messages for maintenance mode request
      https://git.proxmox.com/?p=pve-ha-manager.git;a=commitdiff;h=9aeb853a02b80596c346501d76e6fec1f6b11c12
[3/6] manager: factor out check for maintenance mode request
      https://git.proxmox.com/?p=pve-ha-manager.git;a=commitdiff;h=b7787287ec1565ed517d7f61f1b175062dc4d808
[4/6] cli: reject maintenance mode requests rejected by crm
      https://git.proxmox.com/?p=pve-ha-manager.git;a=commitdiff;h=669933296ffd2854b96e7cf64014d62aaf737a11
[5/6] api: status: report maintenance mode request for lrm entries
      https://git.proxmox.com/?p=pve-ha-manager.git;a=commitdiff;h=a885666e11be7365209cd189b9a253e044aa5091
[6/6] api: status: report queued maintenance mode request for lrm entries
      https://git.proxmox.com/?p=pve-ha-manager.git;a=commitdiff;h=ef9c125a0277a80289e045a917eaa342fb17199f

[pve-manager] applied to pve-manager.git (master)
[1/3] fix #6144: api: nodes: add endpoint to set maintenance mode
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=b65fde432d9a6a5d529b54a10e8bd6126bf3e978
[2/3] fix #6144: ui: ha: status: allow toggling maintenance mode
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=96a8910070db987bb063f21f834aa97298e0d215
[3/3] ui: ha: status: show spinner while maintenance mode request is queued
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=62c6654ee8eaeddec412dd8b4d053c946cb9b29b




      parent reply	other threads:[~2026-11-19 22:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  9:59 [PATCH-SERIES docs/ha-manager/manager v5 00/10] fix #6144: add api and ui for node maintenance mode Dominik Rusovac
2026-11-19  9:59 ` [PATCH pve-manager v5 01/10] fix #6144: api: nodes: add endpoint to set " Dominik Rusovac
2026-11-19  9:59 ` [PATCH pve-manager v5 02/10] fix #6144: ui: ha: status: allow toggling " Dominik Rusovac
2026-11-19  9:59 ` [PATCH pve-manager v5 03/10] ui: ha: status: show spinner while maintenance mode request is queued Dominik Rusovac
2026-11-19  9:59 ` [PATCH pve-ha-manager v5 04/10] test: add test for ignoring maintenance mode request Dominik Rusovac
2026-11-19  9:59 ` [PATCH pve-ha-manager v5 05/10] manager: standardize log messages for " Dominik Rusovac
2026-11-19  9:59 ` [PATCH pve-ha-manager v5 06/10] manager: factor out check " Dominik Rusovac
2026-11-19  9:59 ` [PATCH pve-ha-manager v5 07/10] cli: reject maintenance mode requests rejected by crm Dominik Rusovac
2026-11-19  9:59 ` [PATCH pve-ha-manager v5 08/10] api: status: report maintenance mode request for lrm entries Dominik Rusovac
2026-11-19  9:59 ` [PATCH pve-ha-manager v5 09/10] api: status: report queued " Dominik Rusovac
2026-11-19  9:59 ` [PATCH pve-docs v5 10/10] ha-manager: maintenance mode: mention web ui menu Dominik Rusovac
2026-11-19 22:28 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179512671723.3646511.14162859267761864497.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=d.rusovac@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal