From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 9C8261FF0DA for ; Thu, 19 Nov 2026 23:29:43 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 49E432177B; Thu, 19 Nov 2026 23:29:42 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Dominik Rusovac Subject: applied: [PATCH-SERIES docs/ha-manager/manager v5 00/10] fix #6144: add api and ui for node maintenance mode Date: Thu, 19 Nov 2026 23:28:53 +0100 Message-ID: <179512671723.3646511.14162859267761864497.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261119095931.1748970-1-d.rusovac@proxmox.com> References: <20261119095931.1748970-1-d.rusovac@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795127376163 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.126 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FHRTB5NMQBFY3TC4GPQ2CQSJGVN2M2TA X-Message-ID-Hash: FHRTB5NMQBFY3TC4GPQ2CQSJGVN2M2TA X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 19 Nov 2026 10:59:21 +0100, Dominik Rusovac wrote: > this picks up Thomas' v3 [0], rebased onto current master and reworked > in a few places; thx for the nice work Thomas! I added `Originally-by` > trailers > > node maintenance mode can currently only be enabled/disabled with the HA > manager's CRM command in the CLI. this series adds an API endpoint and a > 'Node Maintenance' menu in the HA status panel for it > > [...] Applied, thanks! I folded some changes into the patches, and added two follow-ups: ha-manager: - the shared check returns the log level and reason instead of taking a log callback, so that the CRM and the CLI each phrase the message; the 'not online' message uses the common format now too - cli: requesting maintenance mode again for a node it is already requested for succeeds, instead of failing with the CRM's "already in maintenance state" log message. The early check only runs while the recorded state is current, i.e. with an active CRM and no other queued command such as arm-ha, otherwise the CRM decides - status API: parse the queued commands in PVE::HA::Config - follow-up: the CRM now records an enable request for a node that is in maintenance without one, e.g. while it shuts down with the 'migrate' shutdown policy, so that it stays in maintenance once back online. This also keeps an enable queued right after a disable manager: - the endpoint requires Sys.Modify on / instead of /nodes/{node}, as maintenance moves HA resources to other nodes; the UI checks the same - ui: Enable is also disabled while HA is still disarming. The spinner tracks pending requests in a Map, as a node named 'constructor' was always pending, keeps them on failed loads and compares them to the start of the load that finished docs: - mention that requests for nodes that are not online are rejected, except during a 'migrate' policy shutdown, which a follow-up documents [pve-docs] applied to pve-docs.git (master) [1/1] ha-manager: maintenance mode: mention web ui menu https://git.proxmox.com/?p=pve-docs.git;a=commitdiff;h=744af141b66235061a729ba226bd2b0644f6cf25 [pve-ha-manager] applied to pve-ha-manager.git (master) [1/6] test: add test for ignoring maintenance mode request https://git.proxmox.com/?p=pve-ha-manager.git;a=commitdiff;h=122e20ce41c19bd62506413b91b39b0e13e4f5fe [2/6] manager: standardize log messages for maintenance mode request https://git.proxmox.com/?p=pve-ha-manager.git;a=commitdiff;h=9aeb853a02b80596c346501d76e6fec1f6b11c12 [3/6] manager: factor out check for maintenance mode request https://git.proxmox.com/?p=pve-ha-manager.git;a=commitdiff;h=b7787287ec1565ed517d7f61f1b175062dc4d808 [4/6] cli: reject maintenance mode requests rejected by crm https://git.proxmox.com/?p=pve-ha-manager.git;a=commitdiff;h=669933296ffd2854b96e7cf64014d62aaf737a11 [5/6] api: status: report maintenance mode request for lrm entries https://git.proxmox.com/?p=pve-ha-manager.git;a=commitdiff;h=a885666e11be7365209cd189b9a253e044aa5091 [6/6] api: status: report queued maintenance mode request for lrm entries https://git.proxmox.com/?p=pve-ha-manager.git;a=commitdiff;h=ef9c125a0277a80289e045a917eaa342fb17199f [pve-manager] applied to pve-manager.git (master) [1/3] fix #6144: api: nodes: add endpoint to set maintenance mode https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=b65fde432d9a6a5d529b54a10e8bd6126bf3e978 [2/3] fix #6144: ui: ha: status: allow toggling maintenance mode https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=96a8910070db987bb063f21f834aa97298e0d215 [3/3] ui: ha: status: show spinner while maintenance mode request is queued https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=62c6654ee8eaeddec412dd8b4d053c946cb9b29b