From: Dominik Rusovac <d.rusovac@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Thomas Skinner <thomas@atskinner.net>
Subject: [PATCH pve-ha-manager v5 08/10] api: status: report maintenance mode request for lrm entries
Date: Thu, 19 Nov 2026 10:59:29 +0100 [thread overview]
Message-ID: <20261119095931.1748970-9-d.rusovac@proxmox.com> (raw)
In-Reply-To: <20261119095931.1748970-1-d.rusovac@proxmox.com>
expose whether maintenance mode was manually requested for a node, as
recorded by the CRM
Originally-by: Thomas Skinner <thomas@atskinner.net>
Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
Reviewed-by: Daniel Kral <d.kral@proxmox.com>
---
Notes:
changes since v4:
* reword commit subject
src/PVE/API2/HA/Status.pm | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/src/PVE/API2/HA/Status.pm b/src/PVE/API2/HA/Status.pm
index aecef0f..2622ec1 100644
--- a/src/PVE/API2/HA/Status.pm
+++ b/src/PVE/API2/HA/Status.pm
@@ -107,6 +107,12 @@ __PACKAGE__->register_method({
type => "integer",
optional => 1,
},
+ 'maintenance-requested' => {
+ description => "For type 'lrm'. Whether maintenance mode was manually"
+ . " requested for the node.",
+ type => "boolean",
+ optional => 1,
+ },
crm_state => {
description => "For type 'service'. Service state as seen by the CRM.",
type => "string",
@@ -265,6 +271,8 @@ __PACKAGE__->register_method({
PVE::HA::Tools::count_active_services($status->{service_status}, $node);
my $lrm_status = PVE::HA::Config::read_lrm_status($node);
my $id = "lrm:$node";
+ my $node_request = $status->{node_request} // {};
+ my $maintenance_requested = $node_request->{$node}->{maintenance} ? 1 : 0;
if (!$lrm_status->{timestamp}) {
push @$res,
{
@@ -272,6 +280,7 @@ __PACKAGE__->register_method({
type => 'lrm',
node => $node,
status => "$node (unable to read lrm status)",
+ 'maintenance-requested' => $maintenance_requested,
};
} else {
my $status_str = &$timestamp_to_status($ctime, $lrm_status->{timestamp});
@@ -315,6 +324,7 @@ __PACKAGE__->register_method({
node => $node,
status => $status_text,
timestamp => $lrm_status->{timestamp},
+ 'maintenance-requested' => $maintenance_requested,
};
}
}
--
2.47.3
next prev parent reply other threads:[~2026-11-19 10:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 9:59 [PATCH-SERIES docs/ha-manager/manager v5 00/10] fix #6144: add api and ui for node maintenance mode Dominik Rusovac
2026-11-19 9:59 ` [PATCH pve-manager v5 01/10] fix #6144: api: nodes: add endpoint to set " Dominik Rusovac
2026-11-19 9:59 ` [PATCH pve-manager v5 02/10] fix #6144: ui: ha: status: allow toggling " Dominik Rusovac
2026-11-19 9:59 ` [PATCH pve-manager v5 03/10] ui: ha: status: show spinner while maintenance mode request is queued Dominik Rusovac
2026-11-19 9:59 ` [PATCH pve-ha-manager v5 04/10] test: add test for ignoring maintenance mode request Dominik Rusovac
2026-11-19 9:59 ` [PATCH pve-ha-manager v5 05/10] manager: standardize log messages for " Dominik Rusovac
2026-11-19 9:59 ` [PATCH pve-ha-manager v5 06/10] manager: factor out check " Dominik Rusovac
2026-11-19 9:59 ` [PATCH pve-ha-manager v5 07/10] cli: reject maintenance mode requests rejected by crm Dominik Rusovac
2026-11-19 9:59 ` Dominik Rusovac [this message]
2026-11-19 9:59 ` [PATCH pve-ha-manager v5 09/10] api: status: report queued maintenance mode request for lrm entries Dominik Rusovac
2026-11-19 9:59 ` [PATCH pve-docs v5 10/10] ha-manager: maintenance mode: mention web ui menu Dominik Rusovac
2026-11-19 22:28 ` applied: [PATCH-SERIES docs/ha-manager/manager v5 00/10] fix #6144: add api and ui for node maintenance mode Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119095931.1748970-9-d.rusovac@proxmox.com \
--to=d.rusovac@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=thomas@atskinner.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox