public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: applied: [PATCH v2 cluster/access-control/docs/manager/proxmox 0/19] fix #7805: add a datacenter-wide API token policy
Date: Wed, 18 Nov 2026 03:17:50 +0100	[thread overview]
Message-ID: <179496826859.1865615.13609877569131474289.b4-ty@b4> (raw)
In-Reply-To: <20261115194043.3947825-1-t.lamprecht@proxmox.com>

On Sun, 15 Nov 2026 20:40:21 +0100, Thomas Lamprecht wrote:
> Compliance rules like PCI DSS, SOC 2, or ISO 27001 often require
> that credentials have a limited lifetime, but there is no central way
> to enforce that for API tokens.
> 
> Add an optional token-policy option to datacenter.cfg to require an
> expiration date, limit the maximum token lifetime, forbid extending
> the expiration date of existing tokens, and require privilege
> separation. Two further opt-in settings help tools that manage their
> own tokens: one gives tokens created without an expiration date the
> maximum lifetime, the other allows extending a token if its secret is
> regenerated in the same request.
> 
> [...]

Applied with @Shannon's latest findings (and a bit more) addressed,
thanks for the review here.

[cluster] applied to pve-cluster.git (master)
[1/3] datacenter config: add token-policy option
      https://git.proxmox.com/?p=pve-cluster.git;a=commitdiff;h=86d121f77d0d7d050ec77ba163bc46eba72b5f63
[2/3] datacenter config: token policy: add default-to-max-lifetime setting
      https://git.proxmox.com/?p=pve-cluster.git;a=commitdiff;h=99e00f926e36b4c018ae378f0f3c43a649253f16
[3/3] datacenter config: token policy: allow extension on regeneration
      https://git.proxmox.com/?p=pve-cluster.git;a=commitdiff;h=15a7665ec979da04bc946414690be8f66f06e00f

[access-control] applied to git/pve-access-control.git (master)
[1/3] fix #7805: api: token: enforce datacenter token policy
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=5550002b8523195ad1f5ca53a238c055db556529
[2/3] api: token: apply the default lifetime from the token policy
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=b41b744e9de677d202d8c7db00b3789946299f00
[3/3] api: token: allow extending tokens on secret regeneration
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=26fda76df278d1dbebf6484a6ede52da4909ef94

[docs] applied to pve-docs.git (master)
[1/3] user management: document the API token policy
      https://git.proxmox.com/?p=pve-docs.git;a=commitdiff;h=e11934fca3459fc4e7d83f4167d3ccbeadde1596
[2/3] user management: document the default-to-max-lifetime setting
      https://git.proxmox.com/?p=pve-docs.git;a=commitdiff;h=7772c77dd855043647602e53cde0bd17765c45bd
[3/3] user management: document extending tokens on secret regeneration
      https://git.proxmox.com/?p=pve-docs.git;a=commitdiff;h=286fa3f1639fdd8c85d3cbb0765486c3290ce6cf

[manager] applied to pve-manager.git (master)
[1/6] ui: token edit: only submit the expiration date when changed
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=123d8fca229c8c576a6e9dd76569dffa6a8b859a
[2/6] api: cluster options: return token-policy without Sys.Audit
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=33d36aab9e3c0bd9cad7b7cd2fff661feb060f12
[3/6] ui: dc options: allow editing the API token policy
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=acf6773e5500b7b770423162a96180e0ae0e1c8c
[4/6] ui: token edit: adapt to the datacenter API token policy
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=684b10c9341b9006bcb5f3bd338e7d821aa4e46b
[5/6] ui: token policy: expose the default-to-max-lifetime setting
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=4735a0bf4c673106ed62fc84d5c6646502c1a7ba
[6/6] ui: token policy: allow extension on secret regeneration
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=ab96a34a1c041442172b1a45776955ad14bb43ff

[proxmox] applied to git/proxmox.git (master)
[1/4] access-control: add API token policy type with expiry checks
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=bf06cacdead7ecf014c759b5b1b0cd150bec7ed5
[2/4] access-control: enforce token policy on token create and update
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=61c9e069436194eb1551c9c241429501816ed64b
[3/4] access-control: apply a default token lifetime from the policy
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=af2980f62fc9ebfd2485fa7df9d3612634c03c53
[4/4] access-control: allow extending tokens on secret regeneration
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=3f925ad1ecc38fb4233e96cc509bf865de1749b4




      parent reply	other threads:[~2026-11-18  2:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 19:40 [PATCH v2 cluster/access-control/docs/manager/proxmox 0/19] fix #7805: add a datacenter-wide API token policy Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 cluster 1/19] datacenter config: add token-policy option Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 cluster 2/19] datacenter config: token policy: add default-to-max-lifetime setting Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 cluster 3/19] datacenter config: token policy: allow extension on regeneration Thomas Lamprecht
2026-11-17 13:30   ` Shannon Sterz
2026-11-15 19:40 ` [PATCH v2 access-control 4/19] fix #7805: api: token: enforce datacenter token policy Thomas Lamprecht
2026-11-17 13:30   ` Shannon Sterz
2026-11-15 19:40 ` [PATCH v2 access-control 5/19] api: token: apply the default lifetime from the " Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 access-control 6/19] api: token: allow extending tokens on secret regeneration Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 docs 7/19] user management: document the API token policy Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 docs 8/19] user management: document the default-to-max-lifetime setting Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 docs 9/19] user management: document extending tokens on secret regeneration Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 10/19] ui: token edit: only submit the expiration date when changed Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 11/19] api: cluster options: return token-policy without Sys.Audit Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 12/19] ui: dc options: allow editing the API token policy Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 13/19] ui: token edit: adapt to the datacenter " Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 14/19] ui: token policy: expose the default-to-max-lifetime setting Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 15/19] ui: token policy: allow extension on secret regeneration Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 proxmox 16/19] access-control: add API token policy type with expiry checks Thomas Lamprecht
2026-11-17 13:29   ` Shannon Sterz
2026-11-15 19:40 ` [PATCH v2 proxmox 17/19] access-control: enforce token policy on token create and update Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 proxmox 18/19] access-control: apply a default token lifetime from the policy Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 proxmox 19/19] access-control: allow extending tokens on secret regeneration Thomas Lamprecht
2026-11-17 13:29   ` Shannon Sterz
2026-11-17 13:29 ` [PATCH v2 cluster/access-control/docs/manager/proxmox 0/19] fix #7805: add a datacenter-wide API token policy Shannon Sterz
2026-11-18  2:17 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179496826859.1865615.13609877569131474289.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal