public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH v2 cluster 3/19] datacenter config: token policy: allow extension on regeneration
Date: Sun, 15 Nov 2026 20:40:24 +0100	[thread overview]
Message-ID: <20261115194043.3947825-4-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20261115194043.3947825-1-t.lamprecht@proxmox.com>

With 'disallow-expiry-extension' set, keeping an integration running
past the maximum lifetime needs a new token with all its permissions
set up again. As creating that token is always possible, the
restriction mostly adds work and discourages narrowly scoped tokens.

Extending a token together with regenerating its secret has the same
effect as recreating it, as the old credential stops working. Add a
setting that allows exactly that, so tools can rotate their tokens in
place, within the maximum lifetime.

Suggested-by: Shannon Sterz <s.sterz@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---

new in v2

 src/PVE/DataCenterConfig.pm   | 8 ++++++++
 src/test/test_token_policy.pl | 3 +++
 2 files changed, 11 insertions(+)

diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
index 330126b..49d1bb6 100644
--- a/src/PVE/DataCenterConfig.pm
+++ b/src/PVE/DataCenterConfig.pm
@@ -303,6 +303,14 @@ my $token_policy_format = {
             . " lifetime instead of rejecting them, for example for tools unaware of the policy."
             . " Has no effect without 'max-lifetime'.",
     },
+    'allow-extension-on-regenerate' => {
+        type => 'boolean',
+        optional => 1,
+        default => 0,
+        description => "Allow extending the expiration date of an existing API token when its"
+            . " secret is regenerated in the same request, despite 'disallow-expiry-extension'."
+            . " The maximum lifetime still applies.",
+    },
     'require-privilege-separation' => {
         type => 'boolean',
         optional => 1,
diff --git a/src/test/test_token_policy.pl b/src/test/test_token_policy.pl
index bcafec1..adcb93a 100644
--- a/src/test/test_token_policy.pl
+++ b/src/test/test_token_policy.pl
@@ -26,6 +26,9 @@ is($policy->{'require-privilege-separation'}, 1, 'require-privilege-separation i
 $policy = $parse->('max-lifetime=86400,default-to-max-lifetime=1')->{'token-policy'};
 is($policy->{'default-to-max-lifetime'}, 1, 'default-to-max-lifetime is parsed');
 
+$policy = $parse->('disallow-expiry-extension=1,allow-extension-on-regenerate=1')->{'token-policy'};
+is($policy->{'allow-extension-on-regenerate'}, 1, 'allow-extension-on-regenerate is parsed');
+
 is($parse->(undef)->{'token-policy'}, undef, 'an absent token-policy is not invented');
 
 # an unusable policy has to be dropped, never half applied, and must not take the rest of the
-- 
2.47.3





  parent reply	other threads:[~2026-11-15 19:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 19:40 [PATCH v2 cluster/access-control/docs/manager/proxmox 0/19] fix #7805: add a datacenter-wide API token policy Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 cluster 1/19] datacenter config: add token-policy option Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 cluster 2/19] datacenter config: token policy: add default-to-max-lifetime setting Thomas Lamprecht
2026-11-15 19:40 ` Thomas Lamprecht [this message]
2026-11-17 13:30   ` [PATCH v2 cluster 3/19] datacenter config: token policy: allow extension on regeneration Shannon Sterz
2026-11-15 19:40 ` [PATCH v2 access-control 4/19] fix #7805: api: token: enforce datacenter token policy Thomas Lamprecht
2026-11-17 13:30   ` Shannon Sterz
2026-11-15 19:40 ` [PATCH v2 access-control 5/19] api: token: apply the default lifetime from the " Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 access-control 6/19] api: token: allow extending tokens on secret regeneration Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 docs 7/19] user management: document the API token policy Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 docs 8/19] user management: document the default-to-max-lifetime setting Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 docs 9/19] user management: document extending tokens on secret regeneration Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 10/19] ui: token edit: only submit the expiration date when changed Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 11/19] api: cluster options: return token-policy without Sys.Audit Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 12/19] ui: dc options: allow editing the API token policy Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 13/19] ui: token edit: adapt to the datacenter " Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 14/19] ui: token policy: expose the default-to-max-lifetime setting Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 15/19] ui: token policy: allow extension on secret regeneration Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 proxmox 16/19] access-control: add API token policy type with expiry checks Thomas Lamprecht
2026-11-17 13:29   ` Shannon Sterz
2026-11-15 19:40 ` [PATCH v2 proxmox 17/19] access-control: enforce token policy on token create and update Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 proxmox 18/19] access-control: apply a default token lifetime from the policy Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 proxmox 19/19] access-control: allow extending tokens on secret regeneration Thomas Lamprecht
2026-11-17 13:29   ` Shannon Sterz
2026-11-17 13:29 ` [PATCH v2 cluster/access-control/docs/manager/proxmox 0/19] fix #7805: add a datacenter-wide API token policy Shannon Sterz
2026-11-18  2:17 ` applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261115194043.3947825-4-t.lamprecht@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal