From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id F20161FF0C0 for ; Wed, 18 Nov 2026 03:19:19 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 068B721631; Wed, 18 Nov 2026 03:19:17 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Thomas Lamprecht Subject: applied: [PATCH v2 cluster/access-control/docs/manager/proxmox 0/19] fix #7805: add a datacenter-wide API token policy Date: Wed, 18 Nov 2026 03:17:50 +0100 Message-ID: <179496826859.1865615.13609877569131474289.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261115194043.3947825-1-t.lamprecht@proxmox.com> References: <20261115194043.3947825-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794968351125 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.067 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HWEI2OGEJ25ZJGGFCZQEUZJ6VCEOP2OG X-Message-ID-Hash: HWEI2OGEJ25ZJGGFCZQEUZJ6VCEOP2OG X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sun, 15 Nov 2026 20:40:21 +0100, Thomas Lamprecht wrote: > Compliance rules like PCI DSS, SOC 2, or ISO 27001 often require > that credentials have a limited lifetime, but there is no central way > to enforce that for API tokens. > > Add an optional token-policy option to datacenter.cfg to require an > expiration date, limit the maximum token lifetime, forbid extending > the expiration date of existing tokens, and require privilege > separation. Two further opt-in settings help tools that manage their > own tokens: one gives tokens created without an expiration date the > maximum lifetime, the other allows extending a token if its secret is > regenerated in the same request. > > [...] Applied with @Shannon's latest findings (and a bit more) addressed, thanks for the review here. [cluster] applied to pve-cluster.git (master) [1/3] datacenter config: add token-policy option https://git.proxmox.com/?p=pve-cluster.git;a=commitdiff;h=86d121f77d0d7d050ec77ba163bc46eba72b5f63 [2/3] datacenter config: token policy: add default-to-max-lifetime setting https://git.proxmox.com/?p=pve-cluster.git;a=commitdiff;h=99e00f926e36b4c018ae378f0f3c43a649253f16 [3/3] datacenter config: token policy: allow extension on regeneration https://git.proxmox.com/?p=pve-cluster.git;a=commitdiff;h=15a7665ec979da04bc946414690be8f66f06e00f [access-control] applied to git/pve-access-control.git (master) [1/3] fix #7805: api: token: enforce datacenter token policy https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=5550002b8523195ad1f5ca53a238c055db556529 [2/3] api: token: apply the default lifetime from the token policy https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=b41b744e9de677d202d8c7db00b3789946299f00 [3/3] api: token: allow extending tokens on secret regeneration https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=26fda76df278d1dbebf6484a6ede52da4909ef94 [docs] applied to pve-docs.git (master) [1/3] user management: document the API token policy https://git.proxmox.com/?p=pve-docs.git;a=commitdiff;h=e11934fca3459fc4e7d83f4167d3ccbeadde1596 [2/3] user management: document the default-to-max-lifetime setting https://git.proxmox.com/?p=pve-docs.git;a=commitdiff;h=7772c77dd855043647602e53cde0bd17765c45bd [3/3] user management: document extending tokens on secret regeneration https://git.proxmox.com/?p=pve-docs.git;a=commitdiff;h=286fa3f1639fdd8c85d3cbb0765486c3290ce6cf [manager] applied to pve-manager.git (master) [1/6] ui: token edit: only submit the expiration date when changed https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=123d8fca229c8c576a6e9dd76569dffa6a8b859a [2/6] api: cluster options: return token-policy without Sys.Audit https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=33d36aab9e3c0bd9cad7b7cd2fff661feb060f12 [3/6] ui: dc options: allow editing the API token policy https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=acf6773e5500b7b770423162a96180e0ae0e1c8c [4/6] ui: token edit: adapt to the datacenter API token policy https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=684b10c9341b9006bcb5f3bd338e7d821aa4e46b [5/6] ui: token policy: expose the default-to-max-lifetime setting https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=4735a0bf4c673106ed62fc84d5c6646502c1a7ba [6/6] ui: token policy: allow extension on secret regeneration https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=ab96a34a1c041442172b1a45776955ad14bb43ff [proxmox] applied to git/proxmox.git (master) [1/4] access-control: add API token policy type with expiry checks https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=bf06cacdead7ecf014c759b5b1b0cd150bec7ed5 [2/4] access-control: enforce token policy on token create and update https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=61c9e069436194eb1551c9c241429501816ed64b [3/4] access-control: apply a default token lifetime from the policy https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=af2980f62fc9ebfd2485fa7df9d3612634c03c53 [4/4] access-control: allow extending tokens on secret regeneration https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=3f925ad1ecc38fb4233e96cc509bf865de1749b4