[PATCH pve-manager v2 1/2] ui: tag menu: remove undefined in title

[PATCH pve-manager v2 1/2] ui: tag menu: remove undefined in title

[Jonas Theisen]

The tag context menu appends the node name to its title if a cluster
name is set, but no node name is ever passed to it, so clustered
setups show "(undefined)".
Remove the cluster name entirely since it is not helpful here anyway.

Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
 www/manager6/dc/CmdMenu.js | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/www/manager6/dc/CmdMenu.js b/www/manager6/dc/CmdMenu.js
index 87671adb..0f010344 100644
--- a/www/manager6/dc/CmdMenu.js
+++ b/www/manager6/dc/CmdMenu.js
@@ -116,9 +116,6 @@ Ext.define('PVE.dc.TagCmdMenu', {
         }
 
         me.title = `${gettext('Tag')} '${me.tag}'`;
-        if (PVE.ClusterName?.length) {
-            me.title += ` (${me.nodename})`;
-        }
 
         me.extraHandlerArgs = {
             prefilterIncludeTag: me.tag,
-- 
2.47.3

[PATCH pve-manager v2 2/2] fix #5001: ui: add context menu with bulk actions for pools in resource tree

[Jonas Theisen]

The pool view groups guests by their pool, but unlike the tag view it
offers no context menu on the pool tree-node itself. Add one with the
same guest bulk actions as the datacenter and tag menus.

The bulk action window opens with the pool filter pre-selected for the
pool the menu was opened on. Only guests that are direct members of
that pool are selected, guests in nested sub-pools are not, matching
how the pool filter works when set manually.

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=5001
Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
 www/manager6/Utils.js             |  4 ++++
 www/manager6/dc/CmdMenu.js        | 23 +++++++++++++++++++++++
 www/manager6/window/BulkAction.js |  3 +++
 3 files changed, 30 insertions(+)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 8b99371d..ced25763 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1630,6 +1630,10 @@ Ext.define('PVE.Utils', {
                 menu = Ext.create('PVE.dc.TagCmdMenu', {
                     tag: record.data.tag,
                 });
+            } else if (type === 'pool') {
+                menu = Ext.create('PVE.dc.PoolCmdMenu', {
+                    pool: record.data.pool,
+                });
             } else if (record?.isRoot()) {
                 menu = Ext.create('PVE.dc.CmdMenu', {
                     pveSelNode: record,
diff --git a/www/manager6/dc/CmdMenu.js b/www/manager6/dc/CmdMenu.js
index 0f010344..a8df2410 100644
--- a/www/manager6/dc/CmdMenu.js
+++ b/www/manager6/dc/CmdMenu.js
@@ -124,3 +124,26 @@ Ext.define('PVE.dc.TagCmdMenu', {
         me.callParent();
     },
 });
+
+Ext.define('PVE.dc.PoolCmdMenu', {
+    extend: 'PVE.dc.CmdMenu',
+    xtype: 'poolCmdMenu',
+
+    minWidth: 220,
+
+    initComponent: function () {
+        let me = this;
+
+        if (!me.pool) {
+            throw 'no pool specified';
+        }
+
+        me.title = `${gettext('Pool')} '${me.pool}'`;
+
+        me.extraHandlerArgs = {
+            prefilterPool: me.pool,
+        };
+
+        me.callParent();
+    },
+});
diff --git a/www/manager6/window/BulkAction.js b/www/manager6/window/BulkAction.js
index 2e3066a3..7e58fb3f 100644
--- a/www/manager6/window/BulkAction.js
+++ b/www/manager6/window/BulkAction.js
@@ -557,6 +557,9 @@ Ext.define('PVE.window.BulkAction', {
         if (me.prefilterIncludeTag) {
             me.down('#includetagfilter').setValue(me.prefilterIncludeTag);
         }
+        if (me.prefilterPool) {
+            me.down('#poolfilter').setValue(me.prefilterPool);
+        }
 
         form.on('validitychange', function () {
             let valid = form.isValid();
-- 
2.47.3

applied: [PATCH pve-manager v2 1/2] ui: tag menu: remove undefined in title

[Dominik Csapak]

On Wed, 04 Nov 2026 11:57:37 +0100, Jonas Theisen wrote:
> The tag context menu appends the node name to its title if a cluster
> name is set, but no node name is ever passed to it, so clustered
> setups show "(undefined)".
> Remove the cluster name entirely since it is not helpful here anyway.

Applied both patches, thanks!

[1/2] ui: tag menu: remove undefined in title
      commit: 60473ab2be42b3e5db4b6a74a5fae862a866b488
[2/2] fix #5001: ui: add context menu with bulk actions for pools in resource tree
      commit: 0383ddeac5f763e0df5052c33cddd666ac2c8dbc