From: Jonas Theisen <j.theisen@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v2 1/2] ui: tag menu: remove undefined in title
Date: Wed, 4 Nov 2026 11:57:37 +0100 [thread overview]
Message-ID: <20261104105742.164370-1-j.theisen@proxmox.com> (raw)
The tag context menu appends the node name to its title if a cluster
name is set, but no node name is ever passed to it, so clustered
setups show "(undefined)".
Remove the cluster name entirely since it is not helpful here anyway.
Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
| 3 ---
1 file changed, 3 deletions(-)
--git a/www/manager6/dc/CmdMenu.js b/www/manager6/dc/CmdMenu.js
index 87671adb..0f010344 100644
--- a/www/manager6/dc/CmdMenu.js
+++ b/www/manager6/dc/CmdMenu.js
@@ -116,9 +116,6 @@ Ext.define('PVE.dc.TagCmdMenu', {
}
me.title = `${gettext('Tag')} '${me.tag}'`;
- if (PVE.ClusterName?.length) {
- me.title += ` (${me.nodename})`;
- }
me.extraHandlerArgs = {
prefilterIncludeTag: me.tag,
--
2.47.3
next reply other threads:[~2026-11-04 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 10:57 Jonas Theisen [this message]
2026-11-04 10:57 ` [PATCH pve-manager v2 2/2] fix #5001: ui: add context menu with bulk actions for pools in resource tree Jonas Theisen
2026-11-04 12:44 ` applied: [PATCH pve-manager v2 1/2] ui: tag menu: remove undefined in title Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104105742.164370-1-j.theisen@proxmox.com \
--to=j.theisen@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox