From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Jakob Klocker <j.klocker@proxmox.com>
Subject: applied: [PATCH container/qemu-server 0/2] qemu: lxc: refuse moving disks/volumes of protected VMs/CTs
Date: Thu, 29 Oct 2026 15:05:42 +0100 [thread overview]
Message-ID: <179328274119.857378.11561074343288011357.b4-ty@b4> (raw)
In-Reply-To: <20260921153545.406664-1-j.klocker@proxmox.com>
On Mon, 21 Sep 2026 17:35:43 +0200, Jakob Klocker wrote:
> According to the documentation, the protection flag on a container
> prevents disk remove and update operations. This is currently not
> enforced for the move operation, as reported on the mailing list [0]:
> a volume can be moved off a protected CT even though the move removes
> it from the source.
>
> VMs are similar, with one difference: the protection flag blocks
> removing a disk but still allows adding one. Moving a disk still
> removes it from the source, so moving a disk away from a protected VM
> should be refused too, but currently is not.
>
> [...]
Applied, thanks!
[pve-container] applied to git/pve-container.git (master)
[1/1] api: refuse moving volumes if container is protected
commit: f78d591365e4d36c399ebe7cb75ee27cfcdf1369
[qemu-server] applied to qemu-server.git (master)
[1/1] api: refuse moving disks if source VM is protected
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=b9ea9ee29f5059be027c8612da93efd2bfa97592
prev parent reply other threads:[~2026-10-29 14:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 15:35 [PATCH container/qemu-server 0/2] qemu: lxc: refuse moving disks/volumes of protected VMs/CTs Jakob Klocker
2026-09-21 15:35 ` [PATCH pve-container 1/2] api: refuse moving volumes if container is protected Jakob Klocker
2026-10-22 13:15 ` Michael Köppl
2026-09-21 15:35 ` [PATCH qemu-server 2/2] api: refuse moving disks if source VM " Jakob Klocker
2026-10-22 13:15 ` Michael Köppl
2026-10-29 14:36 ` Fiona Ebner
2026-10-22 13:15 ` [PATCH container/qemu-server 0/2] qemu: lxc: refuse moving disks/volumes of protected VMs/CTs Michael Köppl
2026-10-29 14:05 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179328274119.857378.11561074343288011357.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=j.klocker@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox