public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Jakob Klocker" <j.klocker@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH container/qemu-server 0/2] qemu: lxc: refuse moving disks/volumes of protected VMs/CTs
Date: Thu, 22 Oct 2026 15:15:05 +0200	[thread overview]
Message-ID: <DMBE7UIPHPMT.10KJ70DMPT5UH@proxmox.com> (raw)
In-Reply-To: <20260921153545.406664-1-j.klocker@proxmox.com>

Thanks for these patches!

Tested the following scenarios:
- Attempted to move a disk from a protected VM to another VM. This was
  denied as expected.
- Moved a disk from an unprotected VM to a protected VM, which worked,
  since adding a disk to a protected VM is not in scope for these
  patches.
- Attempted to move a volume from an unprotected container to a
  protected one as well as from a protected one to an unprotected one.
  Both were denied with "cannot move volumes to a protected container".

Even though the actions above all work as expected, I noticed that the
behavior is different between CTs and VMs regarding moving a disk/volume
to another storage. I'm not entirely sure that's in scope, though. I
added a comment on the qemu-server patch regarding that.

I also looked at the implementation and added comments to the individual
patches.

On Mon Sep 21, 2026 at 5:35 PM CEST, Jakob Klocker wrote:
> According to the documentation, the protection flag on a container
> prevents disk remove and update operations. This is currently not
> enforced for the move operation, as reported on the mailing list [0]:
> a volume can be moved off a protected CT even though the move removes
> it from the source.
>
> VMs are similar, with one difference: the protection flag blocks
> removing a disk but still allows adding one. Moving a disk still
> removes it from the source, so moving a disk away from a protected VM

[snip]




      parent reply	other threads:[~2026-10-22 13:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 15:35 [PATCH container/qemu-server 0/2] qemu: lxc: refuse moving disks/volumes of protected VMs/CTs Jakob Klocker
2026-09-21 15:35 ` [PATCH pve-container 1/2] api: refuse moving volumes if container is protected Jakob Klocker
2026-10-22 13:15   ` Michael Köppl
2026-09-21 15:35 ` [PATCH qemu-server 2/2] api: refuse moving disks if source VM " Jakob Klocker
2026-10-22 13:15   ` Michael Köppl
2026-10-22 13:15 ` Michael Köppl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMBE7UIPHPMT.10KJ70DMPT5UH@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=j.klocker@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal