From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id DD4021FF0BC for ; Thu, 29 Oct 2026 15:06:04 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 10D8D214DF; Thu, 29 Oct 2026 15:05:56 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Jakob Klocker Subject: applied: [PATCH container/qemu-server 0/2] qemu: lxc: refuse moving disks/volumes of protected VMs/CTs Date: Thu, 29 Oct 2026 15:05:42 +0100 Message-ID: <179328274119.857378.11561074343288011357.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260921153545.406664-1-j.klocker@proxmox.com> References: <20260921153545.406664-1-j.klocker@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793282751819 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.437 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MBVJCKB2WRSR72Z4J4Y7MBN67FJOICPQ X-Message-ID-Hash: MBVJCKB2WRSR72Z4J4Y7MBN67FJOICPQ X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 21 Sep 2026 17:35:43 +0200, Jakob Klocker wrote: > According to the documentation, the protection flag on a container > prevents disk remove and update operations. This is currently not > enforced for the move operation, as reported on the mailing list [0]: > a volume can be moved off a protected CT even though the move removes > it from the source. > > VMs are similar, with one difference: the protection flag blocks > removing a disk but still allows adding one. Moving a disk still > removes it from the source, so moving a disk away from a protected VM > should be refused too, but currently is not. > > [...] Applied, thanks! [pve-container] applied to git/pve-container.git (master) [1/1] api: refuse moving volumes if container is protected commit: f78d591365e4d36c399ebe7cb75ee27cfcdf1369 [qemu-server] applied to qemu-server.git (master) [1/1] api: refuse moving disks if source VM is protected https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=b9ea9ee29f5059be027c8612da93efd2bfa97592