[PATCH storage] plugin: rbd: export: skip 'rbd du' when querying the size

[PATCH storage] plugin: rbd: export: skip 'rbd du' when querying the size

[Kefu Chai]

volume_export() only needs the image size, but it calls
volume_size_info() in list context. In that context volume_size_info()
also runs 'rbd du' to get the used space, which walks every object on
images without fast-diff. The export then never uses the result.

Call it in scalar context.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 src/PVE/Storage/RBDPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm
index 2d1d7a6..b5e82c7 100644
--- a/src/PVE/Storage/RBDPlugin.pm
+++ b/src/PVE/Storage/RBDPlugin.pm
@@ -1016,7 +1016,7 @@ sub volume_export {
     die "cannot export volumes together with their snapshots in $class\n" if $with_snapshots;
     die "cannot export an incremental stream in $class\n" if defined($base_snapshot);
 
-    my ($size) = $class->volume_size_info($scfg, $storeid, $volname);
+    my $size = $class->volume_size_info($scfg, $storeid, $volname);
     PVE::Storage::Plugin::write_common_header($fh, $size);
     my $cmd = $rbd_cmd->($scfg, $storeid, 'export', '--export-format', '1', $volname, '-');
     run_rbd_command(
-- 
2.47.3

applied: [PATCH storage] plugin: rbd: export: skip 'rbd du' when querying the size

[Thomas Lamprecht]

On Wed, 21 Oct 2026 20:21:11 +0800, Kefu Chai wrote:
> volume_export() only needs the image size, but it calls
> volume_size_info() in list context. In that context volume_size_info()
> also runs 'rbd du' to get the used space, which walks every object on
> images without fast-diff. The export then never uses the result.
> 
> Call it in scalar context.
> 
> [...]

Applied, thanks!

[1/1] plugin: rbd: export: skip 'rbd du' when querying the size
      https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=a8ee8394bf6cbd340e1494f39d9f599553a1d141