From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id E73B51FF0B3 for ; Wed, 28 Oct 2026 20:34:23 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 503B521665; Wed, 28 Oct 2026 20:34:01 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Kefu Chai Subject: applied: [PATCH storage] plugin: rbd: export: skip 'rbd du' when querying the size Date: Wed, 28 Oct 2026 20:33:45 +0100 Message-ID: <179321601973.2227346.17789076978328485696.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261021122111.4181795-1-k.chai@proxmox.com> References: <20261021122111.4181795-1-k.chai@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793216034584 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.459 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KXXKAS5SCF23GDINZLZO57UPN2RMOY2S X-Message-ID-Hash: KXXKAS5SCF23GDINZLZO57UPN2RMOY2S X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 21 Oct 2026 20:21:11 +0800, Kefu Chai wrote: > volume_export() only needs the image size, but it calls > volume_size_info() in list context. In that context volume_size_info() > also runs 'rbd du' to get the used space, which walks every object on > images without fast-diff. The export then never uses the result. > > Call it in scalar context. > > [...] Applied, thanks! [1/1] plugin: rbd: export: skip 'rbd du' when querying the size https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=a8ee8394bf6cbd340e1494f39d9f599553a1d141