public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH manager v2] postinst: add nbd devices to global lvm filter.
@ 2026-07-08  6:59 Daniel Herzig
  2026-07-15 20:30 ` applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Herzig @ 2026-07-08  6:59 UTC (permalink / raw)
  To: pve-devel

This patch adds kernel NBD devices to the global filter list of LVM
for new installations.

This is to avoid clashes with existing VGs/LVs on the host system, if
external disks mapped via the nbd kernel driver contain the same
naming scheme (e.g. nested Proxmox VE systems with LVM/ext4
installation on an LVM/ext4 host).

As kernel NBD devices are used by some external backup providers for
certain operations, this may prevent unexpected situations on systems
that make use of these tools.

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
---
Superseeds v1:
https://lore.proxmox.com/pve-devel/20260706070306.36846-1-d.herzig@proxmox.com/

Changes since v1:
* fixed commit message.

 debian/postinst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/postinst b/debian/postinst
index 924e078d..eb7f3356 100755
--- a/debian/postinst
+++ b/debian/postinst
@@ -26,7 +26,7 @@ set_lvm_conf() {
     export LVM_SUPPRESS_FD_WARNINGS=1
 
     OLD_VALUE="$(lvmconfig --typeconfig diff devices/global_filter || true)"
-    NEW_VALUE='global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]'
+    NEW_VALUE='global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|","r|/dev/nbd.*|"]'
 
     # update global_filter if:
     # it is empty and there is no marker OR exactly the one we set before 8.1.4
-- 
2.47.3




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* applied: [PATCH manager v2] postinst: add nbd devices to global lvm filter.
  2026-07-08  6:59 [PATCH manager v2] postinst: add nbd devices to global lvm filter Daniel Herzig
@ 2026-07-15 20:30 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-07-15 20:30 UTC (permalink / raw)
  To: pve-devel, Daniel Herzig

On Wed, 08 Jul 2026 08:59:35 +0200, Daniel Herzig wrote:
> This patch adds kernel NBD devices to the global filter list of LVM
> for new installations.
> 
> This is to avoid clashes with existing VGs/LVs on the host system, if
> external disks mapped via the nbd kernel driver contain the same
> naming scheme (e.g. nested Proxmox VE systems with LVM/ext4
> installation on an LVM/ext4 host).
> 
> [...]

Applied, thanks!

[1/1] postinst: add nbd devices to global lvm filter.
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=78d1042eab654f71b1ce4c6f405a80ca2c935e8a




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-15 20:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-08  6:59 [PATCH manager v2] postinst: add nbd devices to global lvm filter Daniel Herzig
2026-07-15 20:30 ` applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal