public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Herzig <d.herzig@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v2] postinst: add nbd devices to global lvm filter.
Date: Wed,  8 Jul 2026 08:59:35 +0200	[thread overview]
Message-ID: <20260708065936.30842-1-d.herzig@proxmox.com> (raw)

This patch adds kernel NBD devices to the global filter list of LVM
for new installations.

This is to avoid clashes with existing VGs/LVs on the host system, if
external disks mapped via the nbd kernel driver contain the same
naming scheme (e.g. nested Proxmox VE systems with LVM/ext4
installation on an LVM/ext4 host).

As kernel NBD devices are used by some external backup providers for
certain operations, this may prevent unexpected situations on systems
that make use of these tools.

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
---
Superseeds v1:
https://lore.proxmox.com/pve-devel/20260706070306.36846-1-d.herzig@proxmox.com/

Changes since v1:
* fixed commit message.

 debian/postinst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/postinst b/debian/postinst
index 924e078d..eb7f3356 100755
--- a/debian/postinst
+++ b/debian/postinst
@@ -26,7 +26,7 @@ set_lvm_conf() {
     export LVM_SUPPRESS_FD_WARNINGS=1
 
     OLD_VALUE="$(lvmconfig --typeconfig diff devices/global_filter || true)"
-    NEW_VALUE='global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]'
+    NEW_VALUE='global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|","r|/dev/nbd.*|"]'
 
     # update global_filter if:
     # it is empty and there is no marker OR exactly the one we set before 8.1.4
-- 
2.47.3




                 reply	other threads:[~2026-07-08  7:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260708065936.30842-1-d.herzig@proxmox.com \
    --to=d.herzig@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal