public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH qemu-server] migrate: Add more context to error message
@ 2026-06-03 14:34 Maximiliano Sandoval
  2026-06-16 12:39 ` Fabian Grünbichler
  0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2026-06-03 14:34 UTC (permalink / raw)
  To: pve-devel

For context, when the target node has a qemu-server version older than
9.0.20, the "nets-host-mtu" option will be unknown to it and migrating a
VM having the option set will fail.

This error message might appear, for example, in a task log and without
any indication of where it was emitted from, which can make debugging
harder.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

Just a small improvement to and error message that came up in a support ticket.

 src/PVE/QemuMigrate.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm
index d4de9f87..ff7b3a39 100644
--- a/src/PVE/QemuMigrate.pm
+++ b/src/PVE/QemuMigrate.pm
@@ -1125,7 +1125,7 @@ sub phase2_start_local_cluster {
         noerr => 1,
     );
 
-    die "target node $self->{node} is too old for preserving VirtIO-net MTU, please upgrade\n"
+    die "target node $self->{node} is too old for preserving VirtIO-net MTU, please upgrade qemu-server\n"
         if $target_nets_host_mtu_not_supported;
 
     die "remote command failed with exit code $exitcode\n" if $exitcode;
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH qemu-server] migrate: Add more context to error message
  2026-06-03 14:34 [PATCH qemu-server] migrate: Add more context to error message Maximiliano Sandoval
@ 2026-06-16 12:39 ` Fabian Grünbichler
  0 siblings, 0 replies; 2+ messages in thread
From: Fabian Grünbichler @ 2026-06-16 12:39 UTC (permalink / raw)
  To: Maximiliano Sandoval, pve-devel

On June 3, 2026 4:34 pm, Maximiliano Sandoval wrote:
> For context, when the target node has a qemu-server version older than
> 9.0.20, the "nets-host-mtu" option will be unknown to it and migrating a
> VM having the option set will fail.
> 
> This error message might appear, for example, in a task log and without
> any indication of where it was emitted from, which can make debugging
> harder.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> Just a small improvement to and error message that came up in a support ticket.
> 
>  src/PVE/QemuMigrate.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm
> index d4de9f87..ff7b3a39 100644
> --- a/src/PVE/QemuMigrate.pm
> +++ b/src/PVE/QemuMigrate.pm
> @@ -1125,7 +1125,7 @@ sub phase2_start_local_cluster {
>          noerr => 1,
>      );
>  
> -    die "target node $self->{node} is too old for preserving VirtIO-net MTU, please upgrade\n"
> +    die "target node $self->{node} is too old for preserving VirtIO-net MTU, please upgrade qemu-server\n"
>          if $target_nets_host_mtu_not_supported;

the changed message reads like a suggestion to upgrade *only*
qemu-server, which can be dangerous if dependency edges are missing by
accident..

>  
>      die "remote command failed with exit code $exitcode\n" if $exitcode;
> -- 
> 2.47.3
> 
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-16 12:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-03 14:34 [PATCH qemu-server] migrate: Add more context to error message Maximiliano Sandoval
2026-06-16 12:39 ` Fabian Grünbichler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal