From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4B10B1FF141 for ; Tue, 16 Jun 2026 14:40:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3EF148320; Tue, 16 Jun 2026 14:40:02 +0200 (CEST) Date: Tue, 16 Jun 2026 14:39:25 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: [PATCH qemu-server] migrate: Add more context to error message To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260603143434.494705-1-m.sandoval@proxmox.com> In-Reply-To: <20260603143434.494705-1-m.sandoval@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1781613401.yj8pmofmdm.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781613513356 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LBYE4CUZ73NRYJGTYTNQCEXHH53VUWPC X-Message-ID-Hash: LBYE4CUZ73NRYJGTYTNQCEXHH53VUWPC X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On June 3, 2026 4:34 pm, Maximiliano Sandoval wrote: > For context, when the target node has a qemu-server version older than > 9.0.20, the "nets-host-mtu" option will be unknown to it and migrating a > VM having the option set will fail. >=20 > This error message might appear, for example, in a task log and without > any indication of where it was emitted from, which can make debugging > harder. >=20 > Signed-off-by: Maximiliano Sandoval > --- >=20 > Just a small improvement to and error message that came up in a support t= icket. >=20 > src/PVE/QemuMigrate.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm > index d4de9f87..ff7b3a39 100644 > --- a/src/PVE/QemuMigrate.pm > +++ b/src/PVE/QemuMigrate.pm > @@ -1125,7 +1125,7 @@ sub phase2_start_local_cluster { > noerr =3D> 1, > ); > =20 > - die "target node $self->{node} is too old for preserving VirtIO-net = MTU, please upgrade\n" > + die "target node $self->{node} is too old for preserving VirtIO-net = MTU, please upgrade qemu-server\n" > if $target_nets_host_mtu_not_supported; the changed message reads like a suggestion to upgrade *only* qemu-server, which can be dangerous if dependency edges are missing by accident.. > =20 > die "remote command failed with exit code $exitcode\n" if $exitcode; > --=20 > 2.47.3 >=20 >=20 >=20 >=20 >=20 >=20