public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Christoph Heiss <c.heiss@proxmox.com>
Subject: applied: [PATCH installer 1/2] sys: net: make routes hash always defined
Date: Wed, 10 Jun 2026 21:41:19 +0200	[thread overview]
Message-ID: <178111992573.1481350.12838262786977925133.b4-ty@b4> (raw)
In-Reply-To: <20260610132710.199825-1-c.heiss@proxmox.com>

On Wed, 10 Jun 2026 15:27:01 +0200, Christoph Heiss wrote:
> The 'dst' key was never set or used, so drop from subroutine
> documentation.
> 
> This especially simplifies the network setup in Rust, dropping an
> additional (and unneeded) level of `Option<>`.
> 
> No functional changes.
> 
> [...]

Applied, thanks!

I added two follow-ups on top, as there can be multiple RA default
routes, one per receiving interface, like Gabriel mentioned:

- record all IPv6 default routes in the run-env, as query_routes()
  kept only the first one per IP version, so consumers could not tell
  whether a specific interface received its default route through an
  RA.

- skip the RA-received gateway only if the management interface itself
  got it, as a same-gateway RA route seen only on another interface
  would otherwise suppress the static gateway for an interface that
  never receives RAs itself, for example with RA guard active on its
  switch port, leaving the installed system without an IPv6 default
  route.

[1/2] sys: net: make routes hash always defined
      commit: 08754aec9d206ba3ab81d040ffee6df2a98c8b74
[2/2] install: do not force gateway to IPv6 RA-received on non-bridged setups
      commit: e27228ad22f223f1b5f43e4dc7481f397d87d342




      parent reply	other threads:[~2026-06-10 19:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 13:27 [PATCH installer 1/2] sys: net: make routes hash always defined Christoph Heiss
2026-06-10 13:27 ` [PATCH installer 2/2] install: do not force gateway to IPv6 RA-received on non-bridged setups Christoph Heiss
2026-06-10 14:38   ` Gabriel Goller
2026-06-10 14:46   ` Gabriel Goller
2026-06-10 19:41 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178111992573.1481350.12838262786977925133.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal