From: Gabriel Goller <g.goller@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH installer 2/2] install: do not force gateway to IPv6 RA-received on non-bridged setups
Date: Wed, 10 Jun 2026 16:38:34 +0200 [thread overview]
Message-ID: <178110231426.224342.8833338666069373379.b4-review@b4> (raw)
In-Reply-To: <20260610132710.199825-2-c.heiss@proxmox.com>
On Wed, 10 Jun 2026 15:27:02 +0200, Christoph Heiss <c.heiss@proxmox.com> wrote:
> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
> index 5f748d66f4ad..d0253600a8f7 100644
> --- a/Proxmox/Install.pm
> +++ b/Proxmox/Install.pm
> @@ -1182,6 +1182,12 @@ sub extract_data {
> }
> }
>
> + my $routes = $run_env->{network}->{routes};
> + my $is_gateway6_from_ra =
> + defined($routes->{gateway6})
> + && $routes->{gateway6}->{gateway} eq $gateway
> + && $routes->{gateway6}->{protocol} eq 'ra';
Aah, this is weird thought because we can have multiple default routes when the
proto is "ra". Is $routes->{gateway6} also the same route inserted in the ui? If
yes, then maybe it's ok if we just select the first default route we find.
Either way we need to ensure that `query_routes` is only called once so that we
always have the same default route.
We could also add support for multiple default routes, but not sure if it's
worth, as we only show one anyway.
--
Gabriel Goller <g.goller@proxmox.com>
next prev parent reply other threads:[~2026-06-10 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 13:27 [PATCH installer 1/2] sys: net: make routes hash always defined Christoph Heiss
2026-06-10 13:27 ` [PATCH installer 2/2] install: do not force gateway to IPv6 RA-received on non-bridged setups Christoph Heiss
2026-06-10 14:38 ` Gabriel Goller [this message]
2026-06-10 14:46 ` Gabriel Goller
2026-06-10 19:41 ` applied: [PATCH installer 1/2] sys: net: make routes hash always defined Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178110231426.224342.8833338666069373379.b4-review@b4 \
--to=g.goller@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox