From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 639311FF13A for ; Wed, 10 Jun 2026 16:38:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A835D11C98; Wed, 10 Jun 2026 16:38:46 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH installer 2/2] install: do not force gateway to IPv6 RA-received on non-bridged setups From: Gabriel Goller To: Christoph Heiss In-Reply-To: <20260610132710.199825-2-c.heiss@proxmox.com> References: <20260610132710.199825-1-c.heiss@proxmox.com> <20260610132710.199825-2-c.heiss@proxmox.com> Date: Wed, 10 Jun 2026 16:38:34 +0200 Message-Id: <178110231426.224342.8833338666069373379.b4-review@b4> X-Mailer: b4 0.15.2 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781102274994 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UCQVCDG4TGG37FQGG3YA4QVOGM4YCOJG X-Message-ID-Hash: UCQVCDG4TGG37FQGG3YA4QVOGM4YCOJG X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 10 Jun 2026 15:27:02 +0200, Christoph Heiss wrote: > diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm > index 5f748d66f4ad..d0253600a8f7 100644 > --- a/Proxmox/Install.pm > +++ b/Proxmox/Install.pm > @@ -1182,6 +1182,12 @@ sub extract_data { > } > } > > + my $routes = $run_env->{network}->{routes}; > + my $is_gateway6_from_ra = > + defined($routes->{gateway6}) > + && $routes->{gateway6}->{gateway} eq $gateway > + && $routes->{gateway6}->{protocol} eq 'ra'; Aah, this is weird thought because we can have multiple default routes when the proto is "ra". Is $routes->{gateway6} also the same route inserted in the ui? If yes, then maybe it's ok if we just select the first default route we find. Either way we need to ensure that `query_routes` is only called once so that we always have the same default route. We could also add support for multiple default routes, but not sure if it's worth, as we only show one anyway. -- Gabriel Goller