From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4DE521FF13A for ; Wed, 10 Jun 2026 21:42:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5762916C23; Wed, 10 Jun 2026 21:42:19 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Christoph Heiss Subject: applied: [PATCH installer 1/2] sys: net: make routes hash always defined Date: Wed, 10 Jun 2026 21:41:19 +0200 Message-ID: <178111992573.1481350.12838262786977925133.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260610132710.199825-1-c.heiss@proxmox.com> References: <20260610132710.199825-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781120457809 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NEXU52AM2NELSZERIPECD22J7VQSQXTX X-Message-ID-Hash: NEXU52AM2NELSZERIPECD22J7VQSQXTX X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 10 Jun 2026 15:27:01 +0200, Christoph Heiss wrote: > The 'dst' key was never set or used, so drop from subroutine > documentation. > > This especially simplifies the network setup in Rust, dropping an > additional (and unneeded) level of `Option<>`. > > No functional changes. > > [...] Applied, thanks! I added two follow-ups on top, as there can be multiple RA default routes, one per receiving interface, like Gabriel mentioned: - record all IPv6 default routes in the run-env, as query_routes() kept only the first one per IP version, so consumers could not tell whether a specific interface received its default route through an RA. - skip the RA-received gateway only if the management interface itself got it, as a same-gateway RA route seen only on another interface would otherwise suppress the static gateway for an interface that never receives RAs itself, for example with RA guard active on its switch port, leaving the installed system without an IPv6 default route. [1/2] sys: net: make routes hash always defined commit: 08754aec9d206ba3ab81d040ffee6df2a98c8b74 [2/2] install: do not force gateway to IPv6 RA-received on non-bridged setups commit: e27228ad22f223f1b5f43e4dc7481f397d87d342