public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH pve-manager] ui: custom cpu model creation: restrict name field to valid IDs
@ 2026-05-21  9:49 Arthur Bied-Charreton
  2026-05-26  8:09 ` applied: " Fiona Ebner
  0 siblings, 1 reply; 2+ messages in thread
From: Arthur Bied-Charreton @ 2026-05-21  9:49 UTC (permalink / raw)
  To: pve-devel

Until now, the frontend would let invalid PVE config IDs through only
for them to be rejected by the backend.

Reflect the backend format restriction (pve-configid) in the UI by
adding the ConfigId vtype to the name field of the custom CPU model
creation window.

Reported-by: Christian Ebner <c.ebner@proxmox.com>
Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/dc/CPUTypeEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/dc/CPUTypeEdit.js b/www/manager6/dc/CPUTypeEdit.js
index 1b56686a..904b50d5 100644
--- a/www/manager6/dc/CPUTypeEdit.js
+++ b/www/manager6/dc/CPUTypeEdit.js
@@ -52,6 +52,7 @@ Ext.define('PVE.dc.CPUTypeEdit', {
                         editable: '{isCreate}',
                         value: '{cputype}',
                     },
+                    vtype: 'ConfigId',
                     name: 'cputype',
                     maxLength: 40,
                     renderer: (val) => val.replace(/^custom-/, ''),
-- 
2.47.3




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* applied: [PATCH pve-manager] ui: custom cpu model creation: restrict name field to valid IDs
  2026-05-21  9:49 [PATCH pve-manager] ui: custom cpu model creation: restrict name field to valid IDs Arthur Bied-Charreton
@ 2026-05-26  8:09 ` Fiona Ebner
  0 siblings, 0 replies; 2+ messages in thread
From: Fiona Ebner @ 2026-05-26  8:09 UTC (permalink / raw)
  To: pve-devel, Arthur Bied-Charreton

On Thu, 21 May 2026 11:49:28 +0200, Arthur Bied-Charreton wrote:
> Until now, the frontend would let invalid PVE config IDs through only
> for them to be rejected by the backend.
> 
> Reflect the backend format restriction (pve-configid) in the UI by
> adding the ConfigId vtype to the name field of the custom CPU model
> creation window.

Applied, thanks!

[1/1] ui: custom cpu model creation: restrict name field to valid IDs
      commit: 7e4a2f38833b8ede5c76295852f7d5e5a51943f7




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-26  8:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-21  9:49 [PATCH pve-manager] ui: custom cpu model creation: restrict name field to valid IDs Arthur Bied-Charreton
2026-05-26  8:09 ` applied: " Fiona Ebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal