public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager] ui: custom cpu model creation: restrict name field to valid IDs
Date: Thu, 21 May 2026 11:49:28 +0200	[thread overview]
Message-ID: <20260521094928.260111-1-a.bied-charreton@proxmox.com> (raw)

Until now, the frontend would let invalid PVE config IDs through only
for them to be rejected by the backend.

Reflect the backend format restriction (pve-configid) in the UI by
adding the ConfigId vtype to the name field of the custom CPU model
creation window.

Reported-by: Christian Ebner <c.ebner@proxmox.com>
Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/dc/CPUTypeEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/dc/CPUTypeEdit.js b/www/manager6/dc/CPUTypeEdit.js
index 1b56686a..904b50d5 100644
--- a/www/manager6/dc/CPUTypeEdit.js
+++ b/www/manager6/dc/CPUTypeEdit.js
@@ -52,6 +52,7 @@ Ext.define('PVE.dc.CPUTypeEdit', {
                         editable: '{isCreate}',
                         value: '{cputype}',
                     },
+                    vtype: 'ConfigId',
                     name: 'cputype',
                     maxLength: 40,
                     renderer: (val) => val.replace(/^custom-/, ''),
-- 
2.47.3




                 reply	other threads:[~2026-05-21  9:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260521094928.260111-1-a.bied-charreton@proxmox.com \
    --to=a.bied-charreton@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal