From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Shannon Sterz <s.sterz@proxmox.com>
Subject: applied: [PATCH manager] ui: vnet edit: disable tag and vlan aware fields instead of hiding them
Date: Tue, 19 May 2026 21:17:52 +0200 [thread overview]
Message-ID: <177921827051.2471084.921508220258463184.b4-ty@b4> (raw)
In-Reply-To: <20260519123741.210988-1-s.sterz@proxmox.com>
On Tue, 19 May 2026 14:37:41 +0200, Shannon Sterz wrote:
> this improves ux as users unfamiliar with the ui can now tell that
> this would be the correct place to set these values, even if the
> currently select zone does not support them. particularly important
> when creating new vnets, where the controller type is not yet selected
> and both fields would be hidden at first.
>
>
> [...]
Applied, but the hide -> disable change shifts the form-submit behavior subtly:
ExtJS skips disabled fields in getSubmitData, so the setValue('') no longer
triggers the deleteEmpty cbind and editing an existing vnet between zones with
different field support fails with the backend rejecting the now-stale value
(e.g. switching from a vlan zone to simple 400s on the leftover tag). Pushed a
follow-up on top that stages an explicit delete for disabled fields in
onGetValues.
While at it pushed a second one to toggle tag.allowBlank dynamically per the
zone plugin constraints (required on vlan/vxlan/evpn, optional on qinq/faucet)
so the UI flags a missing tag locally instead of round- tripping to the API,
that one was pre-existing though.
Thanks!
[1/1] ui: vnet edit: disable tag and vlan aware fields instead of hiding them
commit: b8448f3981e7f39f6b6057d7309f8bcac9503890
prev parent reply other threads:[~2026-05-19 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 12:37 [PATCH manager] ui: vnet edit: disable tag and vlan aware fields instead of hiding them Shannon Sterz
2026-05-19 19:17 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177921827051.2471084.921508220258463184.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox