Re: applied: [PATCH manager] ui: vnet edit: disable tag and vlan aware fields instead of hiding them

["Shannon Sterz" <s.sterz@proxmox.com>]

On Tue May 19, 2026 at 9:17 PM CEST, Thomas Lamprecht wrote:
> On Tue, 19 May 2026 14:37:41 +0200, Shannon Sterz wrote:
>> this improves ux as users unfamiliar with the ui can now tell that
>> this would be the correct place to set these values, even if the
>> currently select zone does not support them. particularly important
>> when creating new vnets, where the controller type is not yet selected
>> and both fields would be hidden at first.
>>
>>
>> [...]
>
> Applied, but the hide -> disable change shifts the form-submit behavior subtly:
> ExtJS skips disabled fields in getSubmitData, so the setValue('') no longer
> triggers the deleteEmpty cbind and editing an existing vnet between zones with
> different field support fails with the backend rejecting the now-stale value
> (e.g. switching from a vlan zone to simple 400s on the leftover tag). Pushed a
> follow-up on top that stages an explicit delete for disabled fields in
> onGetValues.
>
> While at it pushed a second one to toggle tag.allowBlank dynamically per the
> zone plugin constraints (required on vlan/vxlan/evpn, optional on qinq/faucet)
> so the UI flags a missing tag locally instead of round- tripping to the API,
> that one was pre-existing though.
>
> Thanks!

thanks for catching that and sorry i missed the submit behavior changes!

> [1/1] ui: vnet edit: disable tag and vlan aware fields instead of hiding them
>       commit: b8448f3981e7f39f6b6057d7309f8bcac9503890