From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6C03C1FF141 for ; Tue, 19 May 2026 21:34:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C5C7B119C3; Tue, 19 May 2026 21:34:29 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Shannon Sterz Subject: applied: [PATCH manager] ui: vnet edit: disable tag and vlan aware fields instead of hiding them Date: Tue, 19 May 2026 21:17:52 +0200 Message-ID: <177921827051.2471084.921508220258463184.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260519123741.210988-1-s.sterz@proxmox.com> References: <20260519123741.210988-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779219217714 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EXOF5F6BAA44FTM3Z2BI2J5H7LGIBTKA X-Message-ID-Hash: EXOF5F6BAA44FTM3Z2BI2J5H7LGIBTKA X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 19 May 2026 14:37:41 +0200, Shannon Sterz wrote: > this improves ux as users unfamiliar with the ui can now tell that > this would be the correct place to set these values, even if the > currently select zone does not support them. particularly important > when creating new vnets, where the controller type is not yet selected > and both fields would be hidden at first. > > > [...] Applied, but the hide -> disable change shifts the form-submit behavior subtly: ExtJS skips disabled fields in getSubmitData, so the setValue('') no longer triggers the deleteEmpty cbind and editing an existing vnet between zones with different field support fails with the backend rejecting the now-stale value (e.g. switching from a vlan zone to simple 400s on the leftover tag). Pushed a follow-up on top that stages an explicit delete for disabled fields in onGetValues. While at it pushed a second one to toggle tag.allowBlank dynamically per the zone plugin constraints (required on vlan/vxlan/evpn, optional on qinq/faucet) so the UI flags a missing tag locally instead of round- tripping to the API, that one was pre-existing though. Thanks! [1/1] ui: vnet edit: disable tag and vlan aware fields instead of hiding them commit: b8448f3981e7f39f6b6057d7309f8bcac9503890