public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH perl-rs] pve-rs: add proxmox-frr-templates to build dependency
@ 2026-04-20 13:58 Shannon Sterz
  2026-04-21  5:55 ` Daniel Kral
  2026-04-21 12:39 ` applied: " Thomas Lamprecht
  0 siblings, 2 replies; 4+ messages in thread
From: Shannon Sterz @ 2026-04-20 13:58 UTC (permalink / raw)
  To: pve-devel

otherwise, building will fails because the templates cannot be found
and statically included.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 pve-rs/debian/control | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pve-rs/debian/control b/pve-rs/debian/control
index 25e2121..27d455a 100644
--- a/pve-rs/debian/control
+++ b/pve-rs/debian/control
@@ -47,6 +47,7 @@ Build-Depends: debhelper-compat (= 13),
                librust-url-2+default-dev,
                libstd-rust-dev <!nocheck>,
                perlmod-bin (>= 0.2.1-1),
+               proxmox-frr-templates,
                rustc:native <!nocheck>,
 Maintainer: Proxmox Support Team <support@proxmox.com>
 Standards-Version: 4.6.1
-- 
2.47.3





^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH perl-rs] pve-rs: add proxmox-frr-templates to build dependency
  2026-04-20 13:58 [PATCH perl-rs] pve-rs: add proxmox-frr-templates to build dependency Shannon Sterz
@ 2026-04-21  5:55 ` Daniel Kral
  2026-04-21  8:55   ` Shannon Sterz
  2026-04-21 12:39 ` applied: " Thomas Lamprecht
  1 sibling, 1 reply; 4+ messages in thread
From: Daniel Kral @ 2026-04-21  5:55 UTC (permalink / raw)
  To: Shannon Sterz, pve-devel

On Mon Apr 20, 2026 at 3:58 PM CEST, Shannon Sterz wrote:
> otherwise, building will fails because the templates cannot be found
> and statically included.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  pve-rs/debian/control | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/pve-rs/debian/control b/pve-rs/debian/control
> index 25e2121..27d455a 100644
> --- a/pve-rs/debian/control
> +++ b/pve-rs/debian/control
> @@ -47,6 +47,7 @@ Build-Depends: debhelper-compat (= 13),
>                 librust-url-2+default-dev,
>                 libstd-rust-dev <!nocheck>,
>                 perlmod-bin (>= 0.2.1-1),
> +               proxmox-frr-templates,
>                 rustc:native <!nocheck>,
>  Maintainer: Proxmox Support Team <support@proxmox.com>
>  Standards-Version: 4.6.1

Good to have here as well, I've noticed it with my pve-rs patches as
well and sent a patch [0] where I put it in the proxmox-frr package
which makes it a transient dependency here :).

[0] https://lore.proxmox.com/pve-devel/20260331090050.128253-1-d.kral@proxmox.com/




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH perl-rs] pve-rs: add proxmox-frr-templates to build dependency
  2026-04-21  5:55 ` Daniel Kral
@ 2026-04-21  8:55   ` Shannon Sterz
  0 siblings, 0 replies; 4+ messages in thread
From: Shannon Sterz @ 2026-04-21  8:55 UTC (permalink / raw)
  To: Daniel Kral, pve-devel

On Tue Apr 21, 2026 at 7:55 AM CEST, Daniel Kral wrote:
> On Mon Apr 20, 2026 at 3:58 PM CEST, Shannon Sterz wrote:
>> otherwise, building will fails because the templates cannot be found
>> and statically included.
>>
>> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
>> ---
>>  pve-rs/debian/control | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/pve-rs/debian/control b/pve-rs/debian/control
>> index 25e2121..27d455a 100644
>> --- a/pve-rs/debian/control
>> +++ b/pve-rs/debian/control
>> @@ -47,6 +47,7 @@ Build-Depends: debhelper-compat (= 13),
>>                 librust-url-2+default-dev,
>>                 libstd-rust-dev <!nocheck>,
>>                 perlmod-bin (>= 0.2.1-1),
>> +               proxmox-frr-templates,
>>                 rustc:native <!nocheck>,
>>  Maintainer: Proxmox Support Team <support@proxmox.com>
>>  Standards-Version: 4.6.1
>
> Good to have here as well, I've noticed it with my pve-rs patches as
> well and sent a patch [0] where I put it in the proxmox-frr package
> which makes it a transient dependency here :).
>
> [0] https://lore.proxmox.com/pve-devel/20260331090050.128253-1-d.kral@proxmox.com/

ah yeah that's probably preferable. sorry i missed your patch here, just
ran into this and wanted to clean it up while im at it :)




^ permalink raw reply	[flat|nested] 4+ messages in thread

* applied: [PATCH perl-rs] pve-rs: add proxmox-frr-templates to build dependency
  2026-04-20 13:58 [PATCH perl-rs] pve-rs: add proxmox-frr-templates to build dependency Shannon Sterz
  2026-04-21  5:55 ` Daniel Kral
@ 2026-04-21 12:39 ` Thomas Lamprecht
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2026-04-21 12:39 UTC (permalink / raw)
  To: pve-devel, Shannon Sterz

On Mon, 20 Apr 2026 15:58:57 +0200, Shannon Sterz wrote:
> otherwise, building will fails because the templates cannot be found
> and statically included.
> 
> 

Applied, thanks!

[1/1] pve-rs: add proxmox-frr-templates to build dependency
      commit: 7899909d8bb0d784b419d1b5e50ee58c6c2c60d9




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-04-21 12:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-20 13:58 [PATCH perl-rs] pve-rs: add proxmox-frr-templates to build dependency Shannon Sterz
2026-04-21  5:55 ` Daniel Kral
2026-04-21  8:55   ` Shannon Sterz
2026-04-21 12:39 ` applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal