From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C63961FF142 for ; Tue, 21 Apr 2026 10:56:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A13091954B; Tue, 21 Apr 2026 10:56:08 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 21 Apr 2026 10:55:33 +0200 Message-Id: Subject: Re: [PATCH perl-rs] pve-rs: add proxmox-frr-templates to build dependency To: "Daniel Kral" , X-Mailer: aerc 0.20.0 References: <20260420135857.297416-1-s.sterz@proxmox.com> In-Reply-To: From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776761649072 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.123 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: J6X7IK5KEZO3DKY5Y526WAVQ5PJVZCRH X-Message-ID-Hash: J6X7IK5KEZO3DKY5Y526WAVQ5PJVZCRH X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Apr 21, 2026 at 7:55 AM CEST, Daniel Kral wrote: > On Mon Apr 20, 2026 at 3:58 PM CEST, Shannon Sterz wrote: >> otherwise, building will fails because the templates cannot be found >> and statically included. >> >> Signed-off-by: Shannon Sterz >> --- >> pve-rs/debian/control | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/pve-rs/debian/control b/pve-rs/debian/control >> index 25e2121..27d455a 100644 >> --- a/pve-rs/debian/control >> +++ b/pve-rs/debian/control >> @@ -47,6 +47,7 @@ Build-Depends: debhelper-compat (=3D 13), >> librust-url-2+default-dev, >> libstd-rust-dev , >> perlmod-bin (>=3D 0.2.1-1), >> + proxmox-frr-templates, >> rustc:native , >> Maintainer: Proxmox Support Team >> Standards-Version: 4.6.1 > > Good to have here as well, I've noticed it with my pve-rs patches as > well and sent a patch [0] where I put it in the proxmox-frr package > which makes it a transient dependency here :). > > [0] https://lore.proxmox.com/pve-devel/20260331090050.128253-1-d.kral@pro= xmox.com/ ah yeah that's probably preferable. sorry i missed your patch here, just ran into this and wanted to clean it up while im at it :)