public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [PATCH pmg-gui] ui: pbs snapshotview: set minWidth for verify toast
Date: Tue, 9 Jun 2026 14:12:38 +0200	[thread overview]
Message-ID: <c47aa48b-b650-4175-bccb-a2a00e510a81@proxmox.com> (raw)
In-Reply-To: <14b67ea1-e779-40f5-b86b-e5b5c902d58c@proxmox.com>

On 2026-06-09 13:52, Dominik Csapak wrote:
> mhmm this is only reproducible on firefox, on chrome(ium) it works
> as intended...
> 

it is for sure a little flaky, but I also got it on chrome (needed more
zoom though)

> while it's probably better than not having it, it'll very likely break
> for other languages too that have longer strings there...
> 
> also extjs is always a bit iffy with non 100% zoom
> 
> i think a more generic solution would be something like this:
> 
> ---8<---
> diff --git a/css/ext6-pmg.css b/css/ext6-pmg.css
> index eabe9de..75950d2 100644
> --- a/css/ext6-pmg.css
> +++ b/css/ext6-pmg.css
> @@ -306,3 +306,7 @@ kbd {
>      padding: 2px 4px;
>      white-space: nowrap;
>  }
> +
> +.pmg-toast-fix-width {
> +    width: max-content !important;
> +}
> diff --git a/js/PBSSnapshotView.js b/js/PBSSnapshotView.js
> index 0d4b2af..3bcb87f 100644
> --- a/js/PBSSnapshotView.js
> +++ b/js/PBSSnapshotView.js
> @@ -53,6 +53,7 @@ Ext.define('PMG.PBSConfig', {
>                          html: gettext('Started verification task on the
> Proxmox Backup Server.'),
>                          iconCls: 'fa fa-check',
>                          autoCloseDelay: 5000,
> +                        bodyCls: 'pmg-toast-fix-width',
>                          closable: true,
>                      });
>                      me.loadSnapshots();
> --->8---
> 
> but this might be a problem when we *want* the text to wrap...
> (maybe an addition max-width etc. could help here, but would
> need more tests)

actually, with `width` (instead of `minWidth`) we get correct vertical
growth. we do have a lot of fixed width stuff all over, maybe just have
it fixed here as well is the best approach..

> 
> On 6/9/26 1:20 PM, Hannes Laimer wrote:
>> Avoid having text wrapped and cut off when zoomed >100%
>>
>> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
>> ---
>>   js/PBSSnapshotView.js | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/js/PBSSnapshotView.js b/js/PBSSnapshotView.js
>> index 0d4b2af..15f6c35 100644
>> --- a/js/PBSSnapshotView.js
>> +++ b/js/PBSSnapshotView.js
>> @@ -51,6 +51,7 @@ Ext.define('PMG.PBSConfig', {
>>                       Ext.toast({
>>                           title: gettext('Verify'),
>>                           html: gettext('Started verification task on
>> the Proxmox Backup Server.'),
>> +                        minWidth: 350,
>>                           iconCls: 'fa fa-check',
>>                           autoCloseDelay: 5000,
>>                           closable: true,
> 





  reply	other threads:[~2026-06-09 12:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 11:21 [PATCH pmg-gui] ui: pbs snapshotview: set minWidth for verify toast Hannes Laimer
2026-06-09 11:53 ` Dominik Csapak
2026-06-09 12:12   ` Hannes Laimer [this message]
2026-06-09 13:36 ` superseded: " Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c47aa48b-b650-4175-bccb-a2a00e510a81@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal