From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A59261FF146 for ; Tue, 09 Jun 2026 14:12:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 853FCF291; Tue, 9 Jun 2026 14:12:40 +0200 (CEST) Message-ID: Date: Tue, 9 Jun 2026 14:12:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pmg-gui] ui: pbs snapshotview: set minWidth for verify toast To: Dominik Csapak , pmg-devel@lists.proxmox.com References: <20260609112118.142094-1-h.laimer@proxmox.com> <14b67ea1-e779-40f5-b86b-e5b5c902d58c@proxmox.com> From: Hannes Laimer Content-Language: en-US In-Reply-To: <14b67ea1-e779-40f5-b86b-e5b5c902d58c@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781007113189 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Q44MH6ZE67J7QELERMOD3G7IVVDXLJZK X-Message-ID-Hash: Q44MH6ZE67J7QELERMOD3G7IVVDXLJZK X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-06-09 13:52, Dominik Csapak wrote: > mhmm this is only reproducible on firefox, on chrome(ium) it works > as intended... > it is for sure a little flaky, but I also got it on chrome (needed more zoom though) > while it's probably better than not having it, it'll very likely break > for other languages too that have longer strings there... > > also extjs is always a bit iffy with non 100% zoom > > i think a more generic solution would be something like this: > > ---8<--- > diff --git a/css/ext6-pmg.css b/css/ext6-pmg.css > index eabe9de..75950d2 100644 > --- a/css/ext6-pmg.css > +++ b/css/ext6-pmg.css > @@ -306,3 +306,7 @@ kbd { >      padding: 2px 4px; >      white-space: nowrap; >  } > + > +.pmg-toast-fix-width { > +    width: max-content !important; > +} > diff --git a/js/PBSSnapshotView.js b/js/PBSSnapshotView.js > index 0d4b2af..3bcb87f 100644 > --- a/js/PBSSnapshotView.js > +++ b/js/PBSSnapshotView.js > @@ -53,6 +53,7 @@ Ext.define('PMG.PBSConfig', { >                          html: gettext('Started verification task on the > Proxmox Backup Server.'), >                          iconCls: 'fa fa-check', >                          autoCloseDelay: 5000, > +                        bodyCls: 'pmg-toast-fix-width', >                          closable: true, >                      }); >                      me.loadSnapshots(); > --->8--- > > but this might be a problem when we *want* the text to wrap... > (maybe an addition max-width etc. could help here, but would > need more tests) actually, with `width` (instead of `minWidth`) we get correct vertical growth. we do have a lot of fixed width stuff all over, maybe just have it fixed here as well is the best approach.. > > On 6/9/26 1:20 PM, Hannes Laimer wrote: >> Avoid having text wrapped and cut off when zoomed >100% >> >> Signed-off-by: Hannes Laimer >> --- >>   js/PBSSnapshotView.js | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/js/PBSSnapshotView.js b/js/PBSSnapshotView.js >> index 0d4b2af..15f6c35 100644 >> --- a/js/PBSSnapshotView.js >> +++ b/js/PBSSnapshotView.js >> @@ -51,6 +51,7 @@ Ext.define('PMG.PBSConfig', { >>                       Ext.toast({ >>                           title: gettext('Verify'), >>                           html: gettext('Started verification task on >> the Proxmox Backup Server.'), >> +                        minWidth: 350, >>                           iconCls: 'fa fa-check', >>                           autoCloseDelay: 5000, >>                           closable: true, >