Re: [PATCH pmg-api 2/2] pmg-smtp-filter: log-headers: trim trailing whitespace

[Dominik Csapak <d.csapak@proxmox.com>]

depending on the subject, we could still have trailing space, e.g.

if the subject is the output of `perl -e 'print "x"x511; print " "; 
print "x";'`
the 512th character is space (but not the at the end pre cutting off)
so it gets printed with space as the last character.

one could argue that this is intended since we probably only
want to trim white space on the actual subject not what we log.

with that said:

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>

On 6/11/26 10:56 AM, Stoiko Ivanov wrote:
> Reported-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>   src/bin/pmg-smtp-filter | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/bin/pmg-smtp-filter b/src/bin/pmg-smtp-filter
> index 7f9cdb85..7aa5865c 100755
> --- a/src/bin/pmg-smtp-filter
> +++ b/src/bin/pmg-smtp-filter
> @@ -714,6 +714,7 @@ sub handle_smtp {
>                   $value = PMG::Utils::decode_rfc1522($value);
>                   # remove non-printable and Unicode format chars to avoid log injection and spoofing
>                   $value =~ s/[^\p{XPosixPrint}]|\p{Cf}/ /g;
> +                $value =~ s/^\s+|\s+$//g;;
>                   return encode('UTF-8', substr($value, 0, 512));
>               };
>               # separate line on purpose, so the log-tracker does not parse it as an event