From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C97821FF13C for ; Thu, 11 Jun 2026 11:09:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 37931341D5; Thu, 11 Jun 2026 11:09:50 +0200 (CEST) Message-ID: Date: Thu, 11 Jun 2026 11:09:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH pmg-api 2/2] pmg-smtp-filter: log-headers: trim trailing whitespace To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20260611085708.1121041-1-s.ivanov@proxmox.com> <20260611085708.1121041-3-s.ivanov@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260611085708.1121041-3-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781168938603 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IL6UPPURXDG2NFYB6HQGNS4BRLDVUZU2 X-Message-ID-Hash: IL6UPPURXDG2NFYB6HQGNS4BRLDVUZU2 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: depending on the subject, we could still have trailing space, e.g. if the subject is the output of `perl -e 'print "x"x511; print " "; print "x";'` the 512th character is space (but not the at the end pre cutting off) so it gets printed with space as the last character. one could argue that this is intended since we probably only want to trim white space on the actual subject not what we log. with that said: Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak On 6/11/26 10:56 AM, Stoiko Ivanov wrote: > Reported-by: Dominik Csapak > Signed-off-by: Stoiko Ivanov > --- > src/bin/pmg-smtp-filter | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/bin/pmg-smtp-filter b/src/bin/pmg-smtp-filter > index 7f9cdb85..7aa5865c 100755 > --- a/src/bin/pmg-smtp-filter > +++ b/src/bin/pmg-smtp-filter > @@ -714,6 +714,7 @@ sub handle_smtp { > $value = PMG::Utils::decode_rfc1522($value); > # remove non-printable and Unicode format chars to avoid log injection and spoofing > $value =~ s/[^\p{XPosixPrint}]|\p{Cf}/ /g; > + $value =~ s/^\s+|\s+$//g;; > return encode('UTF-8', substr($value, 0, 512)); > }; > # separate line on purpose, so the log-tracker does not parse it as an event