From: "Max R. Carrara" <m.carrara@proxmox.com>
To: "Stoiko Ivanov" <s.ivanov@proxmox.com>, <pmg-devel@lists.proxmox.com>
Subject: Re: [PATCH pmg-api/pmg-docs/pmg-gui v2 0/5] tracking-center: make input-base configurable
Date: Wed, 10 Jun 2026 18:26:27 +0200 [thread overview]
Message-ID: <DJ5IDD9OR8HE.ENMUIGWPW37U@proxmox.com> (raw)
In-Reply-To: <20260609200637.904334-1-s.ivanov@proxmox.com>
On Tue Jun 9, 2026 at 10:04 PM CEST, Stoiko Ivanov wrote:
> v1->v2:
> * address Thomas feedback (thx!!): add patch 1/5 to pmg-api to mark
> config-options as root_only. (and the change to 1/5 to set
> 'root_only' for the 'log-tracker-base' parameter
> all other patches remain as they were.
>
> It's been a good while since I looked through the SectionConfig code - so
> some feedback by someone more familiar with it would be appreciated (maybe
> Max?)
>
> minimally tested it by logging in as root@pam, and regular admin user
> and trying to change the log-tracker-base option (and others).
>
> cover-letter and discussion for v1:
> https://lore.proxmox.com/pmg-devel/20260608112952.679449-1-s.ivanov@proxmox.com/T/#t
>
> [...]
Overall LGTM -- a few comments inline.
Works as advertised; verified that the config option can be changed by
root only and that other admin users can't change it. Also tested this
with a user with the "Helpdesk" role, just for good measure.
Overall pretty neat! Will add my trailers upon refresh.
next prev parent reply other threads:[~2026-06-10 16:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 20:04 [PATCH pmg-api/pmg-docs/pmg-gui v2 0/5] tracking-center: make input-base configurable Stoiko Ivanov
2026-06-09 20:04 ` [PATCH pmg-api v2 1/5] config: add root_only paramter option Stoiko Ivanov
2026-06-10 16:26 ` Max R. Carrara
2026-06-09 20:04 ` [PATCH pmg-api v2 2/5] config: add log-tracker-base key Stoiko Ivanov
2026-06-10 16:26 ` Max R. Carrara
2026-06-09 20:04 ` [PATCH pmg-api v2 3/5] fix #3657: api: tracking center: explicitly set input base from config Stoiko Ivanov
2026-06-09 20:04 ` [PATCH pmg-gui v2 4/5] fix #3657: system options: add log-tracker-base textrow Stoiko Ivanov
2026-06-10 16:26 ` Max R. Carrara
2026-06-09 20:04 ` [PATCH pmg-docs v2 5/5] pmg-log-tracker: mention that input-base can be configured via GUI Stoiko Ivanov
2026-06-10 16:26 ` Max R. Carrara
2026-06-10 16:26 ` Max R. Carrara [this message]
2026-06-12 17:43 ` superseded: [PATCH pmg-api/pmg-docs/pmg-gui v2 0/5] tracking-center: make input-base configurable Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJ5IDD9OR8HE.ENMUIGWPW37U@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox