From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E1F7A1FF13A for ; Wed, 10 Jun 2026 18:27:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BEFDB1459D; Wed, 10 Jun 2026 18:27:01 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 10 Jun 2026 18:26:27 +0200 Message-Id: Subject: Re: [PATCH pmg-api/pmg-docs/pmg-gui v2 0/5] tracking-center: make input-base configurable To: "Stoiko Ivanov" , From: "Max R. Carrara" X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20260609200637.904334-1-s.ivanov@proxmox.com> In-Reply-To: <20260609200637.904334-1-s.ivanov@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781108740907 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.081 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BYC44C3BNVATDPJCICX44CYHDCMPOVD6 X-Message-ID-Hash: BYC44C3BNVATDPJCICX44CYHDCMPOVD6 X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Jun 9, 2026 at 10:04 PM CEST, Stoiko Ivanov wrote: > v1->v2: > * address Thomas feedback (thx!!): add patch 1/5 to pmg-api to mark > config-options as root_only. (and the change to 1/5 to set > 'root_only' for the 'log-tracker-base' parameter > all other patches remain as they were. > > It's been a good while since I looked through the SectionConfig code - so > some feedback by someone more familiar with it would be appreciated (mayb= e > Max?) > > minimally tested it by logging in as root@pam, and regular admin user > and trying to change the log-tracker-base option (and others). > > cover-letter and discussion for v1: > https://lore.proxmox.com/pmg-devel/20260608112952.679449-1-s.ivanov@proxm= ox.com/T/#t > > [...] Overall LGTM -- a few comments inline. Works as advertised; verified that the config option can be changed by root only and that other admin users can't change it. Also tested this with a user with the "Helpdesk" role, just for good measure. Overall pretty neat! Will add my trailers upon refresh.