From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: superseded: [PATCH pmg-api/pmg-docs/pmg-gui v2 0/5] tracking-center: make input-base configurable
Date: Fri, 12 Jun 2026 19:43:38 +0200 [thread overview]
Message-ID: <20260612194338.1348649f@rosa.proxmox.com> (raw)
In-Reply-To: <20260609200637.904334-1-s.ivanov@proxmox.com>
by:
https://lore.proxmox.com/pmg-devel/20260612174145.1190233-1-s.ivanov@proxmox.com/
Thanks @Max for the review and tests!
On Tue, 9 Jun 2026 22:04:42 +0200
Stoiko Ivanov <s.ivanov@proxmox.com> wrote:
> v1->v2:
> * address Thomas feedback (thx!!): add patch 1/5 to pmg-api to mark
> config-options as root_only. (and the change to 1/5 to set
> 'root_only' for the 'log-tracker-base' parameter
> all other patches remain as they were.
>
> It's been a good while since I looked through the SectionConfig code - so
> some feedback by someone more familiar with it would be appreciated (maybe
> Max?)
>
> minimally tested it by logging in as root@pam, and regular admin user
> and trying to change the log-tracker-base option (and others).
>
> cover-letter and discussion for v1:
> https://lore.proxmox.com/pmg-devel/20260608112952.679449-1-s.ivanov@proxmox.com/T/#t
>
>
> pmg-api:
>
> Stoiko Ivanov (3):
> config: add root_only paramter option.
> config: add log-tracker-base key
> fix #3657: api: tracking center: explicitly set input base from config
>
> src/PMG/API2/Config.pm | 10 +++++++++-
> src/PMG/API2/MailTracker.pm | 5 +++++
> src/PMG/Config.pm | 7 +++++++
> 3 files changed, 21 insertions(+), 1 deletion(-)
>
>
> pmg-gui:
>
> Stoiko Ivanov (1):
> fix #3657: system options: add log-tracker-base textrow
>
> js/SystemOptions.js | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>
> pmg-docs:
>
> Stoiko Ivanov (1):
> pmg-log-tracker: mention that input-base can be configured via GUI
>
> pmg-log-tracker.adoc | 3 +++
> 1 file changed, 3 insertions(+)
>
>
> Summary over all repositories:
> 5 files changed, 30 insertions(+), 1 deletions(-)
>
prev parent reply other threads:[~2026-06-12 17:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 20:04 [PATCH pmg-api/pmg-docs/pmg-gui v2 0/5] tracking-center: make input-base configurable Stoiko Ivanov
2026-06-09 20:04 ` [PATCH pmg-api v2 1/5] config: add root_only paramter option Stoiko Ivanov
2026-06-10 16:26 ` Max R. Carrara
2026-06-09 20:04 ` [PATCH pmg-api v2 2/5] config: add log-tracker-base key Stoiko Ivanov
2026-06-10 16:26 ` Max R. Carrara
2026-06-09 20:04 ` [PATCH pmg-api v2 3/5] fix #3657: api: tracking center: explicitly set input base from config Stoiko Ivanov
2026-06-09 20:04 ` [PATCH pmg-gui v2 4/5] fix #3657: system options: add log-tracker-base textrow Stoiko Ivanov
2026-06-10 16:26 ` Max R. Carrara
2026-06-09 20:04 ` [PATCH pmg-docs v2 5/5] pmg-log-tracker: mention that input-base can be configured via GUI Stoiko Ivanov
2026-06-10 16:26 ` Max R. Carrara
2026-06-10 16:26 ` [PATCH pmg-api/pmg-docs/pmg-gui v2 0/5] tracking-center: make input-base configurable Max R. Carrara
2026-06-12 17:43 ` Stoiko Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260612194338.1348649f@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox