public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-gui 1/1] spam quarantine: add columsn for positive/negative spam score matches
Date: Wed, 3 Jun 2026 02:03:29 +0200	[thread overview]
Message-ID: <52153be0-6383-4da9-95c6-e4a75d9b97f7@proxmox.com> (raw)
In-Reply-To: <e629429f-b193-49e2-91cd-84642e1e7927@proxmox.com>

Am 29.09.25 um 15:43 schrieb Thomas Lamprecht:
> Am 22.09.25 um 10:05 schrieb Dominik Csapak:
>> The api returns the sum of spam matches individually for positive and
>> negative ones, so add two new columns that show them. They each take up
>> 50 pixels, so increase the width of the list by 100 pixel so we have the
>> same space for the other columns here.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>  js/SpamQuarantine.js | 16 +++++++++++++++-
>>  1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/js/SpamQuarantine.js b/js/SpamQuarantine.js
>> index 1844022..93c411d 100644
>> --- a/js/SpamQuarantine.js
>> +++ b/js/SpamQuarantine.js
>> @@ -153,7 +153,7 @@ Ext.define('PMG.SpamQuarantine', {
>>              selModel: 'checkboxmodel',
>>              reference: 'list',
>>              region: 'west',
>> -            width: 500,
>> +            width: 600,
> 
> The quarantine needs a relatively big viewport already as is, due to
> navigation taking up a lot of unused space and the quarantine list
> also needing space to show most useful info.
> 
> While the layout of the navigation might be something to reconsider
> in the future, I'd probably not touch that now. But as each row in
> the list spans over two rows anyway, we potentially could keep using
> a single row column and put the +/- info both into a second row instead.
> 
> But IMO there is no pressure to look into that now, as due to lack of
> feedback from others until now and PMG progressing towards a release
> soonish at least I won't apply this now, there's always a next release.
oof, I forgot this, and now did just the same thing; sorry! But at least
you got some redemption about being right here I guess.




      reply	other threads:[~2026-06-03  0:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22  8:04 [pmg-devel] [PATCH pmg-api/pmg-gui 0/2] spam quarantine: show split positive/negative scores in list Dominik Csapak
2025-09-22  8:05 ` [pmg-devel] [PATCH pmg-api 1/1] api: quarantine: include positive and negative spam score sum " Dominik Csapak
2025-09-22  8:05 ` [pmg-devel] [PATCH pmg-gui 1/1] spam quarantine: add columsn for positive/negative spam score matches Dominik Csapak
2025-09-29 13:42   ` Thomas Lamprecht
2026-06-03  0:03     ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52153be0-6383-4da9-95c6-e4a75d9b97f7@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal