From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4174A1FF13B for ; Wed, 03 Jun 2026 02:04:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE0131FBED; Wed, 3 Jun 2026 02:04:04 +0200 (CEST) Message-ID: <52153be0-6383-4da9-95c6-e4a75d9b97f7@proxmox.com> Date: Wed, 3 Jun 2026 02:03:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [pmg-devel] [PATCH pmg-gui 1/1] spam quarantine: add columsn for positive/negative spam score matches From: Thomas Lamprecht To: Dominik Csapak , pmg-devel@lists.proxmox.com References: <20250922080509.737332-1-d.csapak@proxmox.com> <20250922080509.737332-3-d.csapak@proxmox.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780444974225 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YUB2M3P7UF6AFIEISHBHEVIADIMP2C5P X-Message-ID-Hash: YUB2M3P7UF6AFIEISHBHEVIADIMP2C5P X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 29.09.25 um 15:43 schrieb Thomas Lamprecht: > Am 22.09.25 um 10:05 schrieb Dominik Csapak: >> The api returns the sum of spam matches individually for positive and >> negative ones, so add two new columns that show them. They each take up >> 50 pixels, so increase the width of the list by 100 pixel so we have the >> same space for the other columns here. >> >> Signed-off-by: Dominik Csapak >> --- >> js/SpamQuarantine.js | 16 +++++++++++++++- >> 1 file changed, 15 insertions(+), 1 deletion(-) >> >> diff --git a/js/SpamQuarantine.js b/js/SpamQuarantine.js >> index 1844022..93c411d 100644 >> --- a/js/SpamQuarantine.js >> +++ b/js/SpamQuarantine.js >> @@ -153,7 +153,7 @@ Ext.define('PMG.SpamQuarantine', { >> selModel: 'checkboxmodel', >> reference: 'list', >> region: 'west', >> - width: 500, >> + width: 600, > > The quarantine needs a relatively big viewport already as is, due to > navigation taking up a lot of unused space and the quarantine list > also needing space to show most useful info. > > While the layout of the navigation might be something to reconsider > in the future, I'd probably not touch that now. But as each row in > the list spans over two rows anyway, we potentially could keep using > a single row column and put the +/- info both into a second row instead. > > But IMO there is no pressure to look into that now, as due to lack of > feedback from others until now and PMG progressing towards a release > soonish at least I won't apply this now, there's always a next release. oof, I forgot this, and now did just the same thing; sorry! But at least you got some redemption about being right here I guess.