Re: [PATCH pmg-api v2] fix #7187: report: add ethtool output for physical interfaces

[Erik Fastermann <e.fastermann@proxmox.com>]

Gentle ping. This patch still cleanly applies on the current master


On 5/13/26 10:21 AM, Erik Fastermann wrote:
> Adding ethtool output to pmg-system-report provides visibility into
> actual and supported NIC link speeds, making it much easier to diagnose
> network performance issues, negotiation failures, and configuration
> mismatches. It also reduces support back-and-forth.
> 
> The implementation mirrors the change in pve-manager, as the report
> functionality is similar in both projects.
> 
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
> ---
> 
>   NOTE: A similar patch was applied to all products:
>   pmg, pve, pbs, pdm.
> 
>   changes since v1:
>   * add a more detailed commit message explaining the rational
>   * wrap in eval to prevent errors crashing the report
>   * use PVE::Tools::shellquote to prevent injection errors
> 
>   src/PMG/Report.pm | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> 
> diff --git a/src/PMG/Report.pm b/src/PMG/Report.pm
> index 84d1b88..d5761e0 100644
> --- a/src/PMG/Report.pm
> +++ b/src/PMG/Report.pm
> @@ -4,6 +4,7 @@ use strict;
>   use warnings;
>   use Mail::SpamAssassin::DnsResolver;
>   
> +use PVE::IPRoute2;
>   use PVE::Tools;
>   use PMG::Utils;
>   
> @@ -58,6 +59,20 @@ my $report_def = {
>       ],
>   };
>   
> +eval {
> +    my $interfaces = PVE::IPRoute2::ip_link_details();
> +
> +    for my $iface (sort keys %{$interfaces}) {
> +        if (PVE::IPRoute2::ip_link_is_physical($interfaces->{$iface})) {
> +            push @{ $report_def->{network} }, "ethtool " . PVE::Tools::shellquote($iface);
> +        }
> +    }
> +};
> +
> +if ($@) {
> +    print STDERR "building ethtool commands failed: $@";
> +}
> +
>   my @report_order = ('general', 'storage', 'network', 'firewall', 'cluster', 'pmg');
>   
>   my $report = '';